Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.fritzbox): Make inputs.fritzbox an internal plugin #16390

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

hdecarne
Copy link
Contributor

@hdecarne hdecarne commented Jan 10, 2025

Summary

This PR provides the inputs.fritzbox plugin for collecting statistics from AVM devices (routers, repeaters, ...). It uses the device's TR-064 interfaces to retrieve the status.

I previously contributed this plugin as an external one. As part of the latest reworks I also converted it into an internal one.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16389

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 10, 2025
@hdecarne hdecarne changed the title feat(inputs.fritzbox): Initial implementation feat(inputs.fritzbox): Make inputs.fritzbox an internal plugin Jan 10, 2025
plugins/inputs/fritzbox/fritzbox.go Outdated Show resolved Hide resolved
plugins/inputs/fritzbox/fritzbox.go Outdated Show resolved Hide resolved
plugins/inputs/fritzbox/fritzbox.go Outdated Show resolved Hide resolved
plugins/inputs/fritzbox/fritzbox.go Outdated Show resolved Hide resolved
plugins/inputs/fritzbox/README.md Outdated Show resolved Hide resolved
plugins/inputs/fritzbox/README.md Outdated Show resolved Hide resolved
@hdecarne
Copy link
Contributor Author

@Hipska I have reworked the plugin accordingly (see comments/commits for details). Please let me know if there are additional issues.

Copy link
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added another round

go.sum Outdated Show resolved Hide resolved
plugins/inputs/fritzbox/fritzbox.go Outdated Show resolved Hide resolved
plugins/inputs/fritzbox/fritzbox.go Outdated Show resolved Hide resolved
plugins/inputs/fritzbox/sample.conf Outdated Show resolved Hide resolved
plugins/inputs/fritzbox/sample.conf Outdated Show resolved Hide resolved
plugins/inputs/fritzbox/fritzbox.go Outdated Show resolved Hide resolved
plugins/inputs/fritzbox/fritzbox.go Outdated Show resolved Hide resolved
plugins/inputs/fritzbox/fritzbox.go Outdated Show resolved Hide resolved
plugins/inputs/fritzbox/fritzbox_test.go Outdated Show resolved Hide resolved
plugins/inputs/fritzbox/fritzbox_test.go Outdated Show resolved Hide resolved
@hdecarne
Copy link
Contributor Author

@Hipska, thanks for the detailed review. I have reworked the plugin's configuration interface overall as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert external plugin inputs.fritzbox into an internal one
2 participants