Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linters): Enable unused-receiver rule for revive #16406

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

zak-pawel
Copy link
Collaborator

Summary

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16190

@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 16, 2025
@DStrand1 DStrand1 assigned srebhan and unassigned DStrand1 Jan 16, 2025
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel! Just a small comment...

plugins/inputs/processes/processes_windows.go Outdated Show resolved Hide resolved
@srebhan srebhan merged commit 7a92925 into influxdata:master Jan 17, 2025
27 checks passed
@github-actions github-actions bot added this to the v1.33.2 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore linter ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter: revive, Rule: unused-receiver - Warns on unused method receivers. Should we enable it?
4 participants