Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock specific lock_ids #213

Merged

Conversation

arlai-mk
Copy link
Contributor

@arlai-mk arlai-mk commented Jan 6, 2025

Description

Closes: #197

This PR allows passing lock_ids for unlocking. It is also backwards-compatible, in the way that if we don't pass lock_ids, it will have the same behavior as previously.

Also, it will skip locks that are not actually expired, instead of erroring out.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Targeted the correct branch
  • Included the necessary unit tests
  • Added/adjusted the necessary interchain tests
  • Added a changelog entry in .changelog
  • Compiled the contracts by using make compile and included content of the artifacts directory into the PR
  • Regenerated front-end schema by using make schema and included generated files into the PR
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

@arlai-mk arlai-mk requested a review from a team as a code owner January 6, 2025 08:11
Copy link
Member

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, lgtm! Could you add a simple changelog entry for it? E.g. see how it is done in https://github.com/informalsystems/hydro/blob/main/.changelog/v2.0.0/features/162-add-liquidity-deployments.md, you can similarly add one under .changelog/unreleased.

Other than that, looks good - I ran the interchain tests locally, and they still pass, so afaict this indeed is backward compatible for outside API calls

edit: clippy is also protesting something minor (you can check by running make clippy locally)
Normally it runs in the CI, but I think something doesn't work because it's from an outside fork, I'll check on that

@p-offtermatt
Copy link
Member

Alright, looking good! I will merge this in!

@p-offtermatt p-offtermatt merged commit 5c0f4a2 into informalsystems:main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants