Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(starknet): Add more integration tests #734

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hoank101
Copy link
Contributor

@hoank101 hoank101 commented Jan 6, 2025

Closes: #638


PR author checklist

For all contributors

For external contributors

@hoank101 hoank101 marked this pull request as ready for review January 7, 2025 23:48
@romac
Copy link
Member

romac commented Jan 8, 2025

Turning this into a draft PR since the implementation is not complete yet.

@romac romac marked this pull request as draft January 8, 2025 10:22
@romac
Copy link
Member

romac commented Jan 17, 2025

@hoank101 Are you planning on picking this up again eventually? What kind of new integration tests do you have in mind?

@hoank101
Copy link
Contributor Author

@hoank101 Are you planning on picking this up again eventually? What kind of new integration tests do you have in mind?

it's ready to test right?

@romac
Copy link
Member

romac commented Jan 20, 2025

@hoank101 Well, the dynamic_validator_set_changes test does not actually changes the validator set between heights. Granted, that requires changes to the app but perhaps you could give it a try if you want?

For the other test, submit_transaction is still a stub and would need to interact with the mempool, which also requires some larger changes to the test framework, so understandable if you don't want to go that route.

Perhaps we can remove the high_load_stress_test and focus on dynamic_validator_set_changes? What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code: Write more integration tests
2 participants