Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hpc-coveralls fork #430

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Add hpc-coveralls fork #430

merged 1 commit into from
Aug 17, 2020

Conversation

sevanspowell
Copy link
Contributor

  • Add a fork of hpc-coveralls to iohk-nix that replaces stack-hpc-coveralls and allows us to stop using stack on our CI/coverage builds.
  • I'm adding a fork because I don't think https://github.com/guillaume-nargeot/hpc-coveralls is still actively maintained.

@sevanspowell sevanspowell requested review from manveru, angerman, rvl, craigem and a team August 12, 2020 02:00
@sevanspowell sevanspowell self-assigned this Aug 12, 2020
rvl
rvl approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. From the pull requests list it does look like that project is unmaintained.

@sevanspowell
Copy link
Contributor Author

Nice. From the pull requests list it does look like that project is unmaintained.

It's a bit sad, but it's a very simple project, so it's not too much of a maintenance burden.

@sevanspowell
Copy link
Contributor Author

This fork of hpc-coveralls adds support for cabal.projects and out-of-source builds (like those from Nix), see my PR here: killy971/hpc-coveralls#84

@sevanspowell
Add hpc-coveralls fork
7350154 
- Add a fork of hpc-coveralls to iohk-nix that replaces
  stack-hpc-coveralls and allows us to stop using stack on our
  CI/coverage builds.
@sevanspowell sevanspowell force-pushed the feature/hpc-coveralls-fork branch from 8043d76 to 7350154 Compare August 12, 2020 03:29
@sevanspowell sevanspowell requested a review from a team August 12, 2020 04:15
@disassembler
Copy link
Collaborator

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 17, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit f38e2fa into master Aug 17, 2020
@iohk-bors iohk-bors bot deleted the feature/hpc-coveralls-fork branch August 17, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

@disassembler disassembler disassembler approved these changes

@manveru manveru Awaiting requested review from manveru

@angerman angerman Awaiting requested review from angerman

@craigem craigem Awaiting requested review from craigem

Assignees

@sevanspowell sevanspowell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sevanspowell @disassembler @rvl