Review of votes and certificates sections of tech report #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrtoledo
requested changes
Jan 10, 2025
There was a problem hiding this comment.
Sorry for the long awaited review.
That's a very well written and exhaustive document. I think the document could be made a bit clearer however, e.g. if we properly define what the committee and quorum are (perhaps it is done in a different section that I have not read) and gave more arguments on why 500 votes (or is it voters?) would be enough. I am not sure reading this PR if this is due to the stake distribution (which I assumed) or the historical number of unique signers.
I have added some questions and corrections (mostly in the alba-mithril-musen sections).
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
bwbush
added a commit
that referenced
this pull request
Jan 17, 2025
- Accepted reviewer suggestions.
- Revised in response to reviewer comments.
- Fixed number of votes.
- Added note on fluctuations in the adversary fraction.
- Added election ID to vote.
- Fixed cross reference in text
- Clarified non-voting probabilities.
- Clarified meaning of V_i.
- Clarified In the centralized prehashed scheme for ALBA.
- Removed variant-specific ALBA equation.
- Added note about naive aggregator.
- Added clarification about ephemeral keys.
- Resolved caution statements.
- Clarified recommendation for committee size and quorum.
- Added reasoning about the decentralization parameter.
- Regularized notation for probability.
- Clarified quorum, committee, etc.
- Corrected terminology.
- Prettied technical report, in preparation for rebase.
bwbush
force-pushed
the
bwbush/review-votecert
branch
from
77a72b0 to
ccfd414
Compare
|
@rrtoledo , thanks so much for your thorough review and helpful suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the votes and certificates sections of the first technical report.