-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use of roxy.shinylive
#1230
use of roxy.shinylive
#1230
Conversation
Unit Tests Summary 1 files 70 suites 1h 6m 8s ⏱️ Results for commit acedc7c. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceTest suite performance difference
Additional test case details
Results for commit d7d849c ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are straightforward, but I have a comment about replacing cdisc_data
with teal_data
in all examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left 2 comments based on what we discovered with roxy.shinylive for teal.modules.general
Update `shinylive` usage in `teal-modules-clinical.Rmd` vignette to use the `roxy.shinylive` package and conditional evaluation based on environment variables.
similar to insightsengineering/teal.modules.general#775
teal_data()
everywhere