Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use of roxy.shinylive #1230

Merged
merged 5 commits into from
Oct 4, 2024
Merged

use of roxy.shinylive #1230

merged 5 commits into from
Oct 4, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Sep 30, 2024

similar to insightsengineering/teal.modules.general#775

  • add "Examples in Shinylive" section where appropriate
    • modify examples code to use teal_data() everywhere
  • add a new "Playground" section in the README with links to the shinylive
  • include shinylive iframe in the getting started vignette

Copy link
Contributor

github-actions bot commented Sep 30, 2024

Unit Tests Summary

    1 files     70 suites   1h 6m 8s ⏱️
  724 tests   614 ✅ 110 💤 0 ❌
1 992 runs  1 767 ✅ 225 💤 0 ❌

Results for commit acedc7c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 30, 2024

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 💚 $131.75$ $-4.96$ $0$ $0$ $0$ $0$
shinytest2-tm_a_mmrm 💚 $733.01$ $-25.93$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💚 $227.33$ $-6.06$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💚 $97.93$ $-2.95$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💚 $171.79$ $-5.74$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_tte 💚 $64.22$ $-3.74$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💚 $105.87$ $-4.25$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💚 $259.50$ $-10.24$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💚 $86.75$ $-5.14$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💚 $125.72$ $-4.99$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💚 $229.64$ $-8.02$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💔 $169.00$ $+2.67$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💚 $64.15$ $-1.70$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💚 $67.43$ $-4.23$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💚 $91.54$ $-2.62$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💚 $72.63$ $-1.02$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💚 $87.34$ $-2.48$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_patyear 💔 $46.83$ $+1.68$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💚 $76.38$ $-1.05$ $0$ $0$ $0$ $0$
shinytest2-tm_t_mult_events 💔 $54.62$ $+1.89$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_basic_info 💔 $40.17$ $+1.67$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💔 $120.48$ $+5.42$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_medical_history 💔 $62.38$ $+4.37$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💔 $73.61$ $+3.54$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💔 $87.59$ $+1.37$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_a_mmrm 💚 $13.14$ $-2.55$ e2e_tm_a_mmrm_Deselection_of_conf_level_throws_validation_error_in_method_t_mmrm_fixed.
shinytest2-tm_a_mmrm 💚 $13.95$ $-3.03$ e2e_tm_a_mmrm_Deselection_of_visit_var_throws_validation_error_in_method_g_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💚 $14.26$ $-1.13$ e2e_tm_a_mmrm_Function_g_mmrm_diagnostic_selection_shows_output_settings_changing_settings_throws_no_validation_errors_and_verify_visibility_of_generated_plots.
shinytest2-tm_a_mmrm 💚 $19.69$ $-3.08$ e2e_tm_a_mmrm_Function_g_mmrm_lsmeans_selection_shows_output_settings_changing_settings_throws_no_validation_errors_and_verify_visibility_of_generated_plots.
shinytest2-tm_g_barchart_simple 💚 $13.76$ $-1.87$ e2e_tm_g_barchart_simple_Module_initializes_in_teal_without_errors_and_produces_output.
shinytest2-tm_g_forest_rsp 💚 $11.35$ $-1.51$ e2e_tm_g_forest_rsp_Module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_forest_tte 💚 $11.55$ $-1.97$ e2e_tm_g_forest_tte_Module_initializes_in_teal_without_errors_and_produces_output.
shinytest2-tm_g_km 💚 $26.98$ $-2.26$ e2e_tm_g_km_Starts_with_specified_collapsed_additional_plot_settings.
shinytest2-tm_g_km 💚 $13.69$ $-2.03$ e2e_tm_g_km_Starts_with_specified_collapsed_comparison_settings.
shinytest2-tm_g_lineplot 💚 $11.55$ $-2.22$ e2e_tm_g_lineplot_Module_initializes_in_teal_without_errors.
shinytest2-tm_g_pp_patient_timeline 💚 $25.50$ $-1.24$ e2e_tm_g_pp_patient_timeline_Encodings_aetime_start_aetime_end_dstime_start_dstime_end_are_shown_only_when_relday_x_axis_is_unchecked.
shinytest2-tm_t_abnormality_by_worst_grade 💚 $11.56$ $-2.51$ e2e_tm_t_abnormality_by_worst_grade_Module_initializes_in_teal_without_errors_and_produces_table_output.
shinytest2-tm_t_events_by_grade 💚 $11.09$ $-2.08$ e2e_tm_t_events_by_grade_Module_initializes_in_teal_without_errors_and_produces_table_output.
shinytest2-tm_t_shift_by_grade 💚 $11.72$ $-1.22$ e2e_tm_t_shift_by_grade_Module_initializes_in_teal_without_errors_and_produces_table_output.

Results for commit d7d849c

♻️ This comment has been updated with latest results.

@pawelru pawelru enabled auto-merge (squash) October 1, 2024 08:02
@pawelru pawelru requested a review from donyunardi October 1, 2024 08:31
@pawelru pawelru added the core label Oct 3, 2024
Copy link
Contributor

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are straightforward, but I have a comment about replacing cdisc_data with teal_data in all examples.

R/tm_g_barchart_simple.R Show resolved Hide resolved
DESCRIPTION Show resolved Hide resolved
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left 2 comments based on what we discovered with roxy.shinylive for teal.modules.general

   Update `shinylive` usage in `teal-modules-clinical.Rmd` vignette to use the `roxy.shinylive` package and conditional evaluation based on environment variables.
@pawelru pawelru merged commit 92d03df into main Oct 4, 2024
31 checks passed
@pawelru pawelru deleted the roxy_shinylive branch October 4, 2024 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants