Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upversion teal.report, rtables, rtables.officer #1250

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

shajoezhu
Copy link
Contributor

Pull Request

Fixes #nnn

Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
@shajoezhu shajoezhu added the sme label Nov 25, 2024
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Unit Tests Summary

    1 files     69 suites   1h 8m 19s ⏱️
  701 tests   591 ✅ 110 💤 0 ❌
1 925 runs  1 700 ✅ 225 💤 0 ❌

Results for commit bfc21d3.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 25, 2024

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 💔 $133.25$ $+4.90$ $0$ $0$ $0$ $0$
shinytest2-tm_a_mmrm 💔 $731.87$ $+10.69$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💔 $230.12$ $+9.67$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💔 $100.05$ $+2.98$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💔 $174.58$ $+6.80$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_tte 💔 $62.98$ $+2.47$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💔 $107.80$ $+4.25$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💔 $266.72$ $+4.45$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💔 $86.14$ $+1.72$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💔 $124.18$ $+1.42$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💔 $248.30$ $+4.66$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💔 $87.25$ $+1.59$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💔 $67.72$ $+3.22$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💔 $96.36$ $+4.17$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💔 $77.68$ $+2.87$ $0$ $0$ $0$ $0$
shinytest2-tm_t_coxreg 💔 $72.85$ $+3.86$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events 💔 $60.75$ $+2.88$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💔 $88.93$ $+4.08$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_patyear 💔 $50.99$ $+1.52$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_summary 💔 $66.00$ $+3.42$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💔 $76.76$ $+2.87$ $0$ $0$ $0$ $0$
shinytest2-tm_t_mult_events 💔 $56.84$ $+2.00$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_basic_info 💔 $41.16$ $+1.34$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💔 $129.33$ $+2.39$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_medical_history 💔 $66.22$ $+1.50$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💔 $75.17$ $+3.47$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💔 $57.31$ $+3.05$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💔 $88.81$ $+4.02$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💔 $80.53$ $+3.84$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💔 $59.01$ $+1.36$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💔 $80.56$ $+1.32$ $0$ $0$ $0$ $0$
shinytest2-tm_t_tte 💔 $67.70$ $+1.46$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_a_mmrm 💔 $47.35$ $+1.31$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_diagnostic.
shinytest2-tm_t_shift_by_grade 💔 $11.42$ $+1.13$ e2e_tm_t_shift_by_grade_Selecting_arm_var_changes_the_table_and_does_not_throw_validation_errors.

Results for commit f0efe8b

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor

m7pr commented Nov 26, 2024

Hey @shajoezhu is this ready for a review?

@shajoezhu
Copy link
Contributor Author

Hey @shajoezhu is this ready for a review?

hi @m7pr , yes please

@m7pr
Copy link
Contributor

m7pr commented Nov 26, 2024

I see a note in R CMD CHECK build

* checking dependencies in R code ... NOTE
Namespace in Imports field not imported from:rtables.officer

DESCRIPTION Outdated Show resolved Hide resolved
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to figure out what's up with rtables.officer

DESCRIPTION Outdated Show resolved Hide resolved
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
@m7pr m7pr enabled auto-merge (squash) November 26, 2024 15:42
@m7pr m7pr merged commit d889a33 into main Nov 26, 2024
28 checks passed
@m7pr m7pr deleted the shajoezhu-patch-1 branch November 26, 2024 15:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants