unfix filter1-vals test

insightsengineering · Apr 17, 2024 · 6303931 · 6303931
1 parent 665fd31
commit 6303931
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/tests/testthat/test-shinytest2-tm_outliers.R b/tests/testthat/test-shinytest2-tm_outliers.R
@@ -84,12 +84,14 @@ testthat::test_that("e2e - tm_outliers:
   app_driver$set_active_module_input("categorical_var-dataset_CO2_singleextract-filter1-col", "Type")
   app_driver$expect_no_shiny_error()
 
-  # testthat::expect_identical(
-  #   app_driver$get_active_module_input("categorical_var-dataset_CO2_singleextract-filter1-vals"),
-  #   "TODO: THIS DOESNT WORK"
-  # )
-  # app_driver$set_active_module_input("categorical_var-dataset_CO2_singleextract-filter1-col", "TODO")
-  # app_driver$expect_no_shiny_error()
+  testthat::expect_identical(
+    app_driver$get_active_module_input("categorical_var-dataset_CO2_singleextract-filter1-vals"),
+    c("Qn1", "Qn2", "Qn3", "Qc1", "Qc2", "Qc3", "Mn1", "Mn2", "Mn3",
+      "Mc1", "Mc2", "Mc3")
+    # THIS WILL HAVE DIFFERENT ORDER ONCE THIS IS FIXED https://github.com/insightsengineering/teal.modules.general/issues/735
+  )
+  app_driver$set_active_module_input("categorical_var-dataset_CO2_singleextract-filter1-col", c("Qn1", "Qn2", "Qn3"))
+  app_driver$expect_no_shiny_error()
 
   app_driver$stop()
 })
@@ -220,10 +222,6 @@ testthat::test_that("e2e - tm_outliers: outliers table is displayed with proper
   testthat::expect_match(table_text, "Outliers.*Missing.*Total")
   statistics <- app_driver$get_active_module_input("categorical_var-dataset_CO2_singleextract-filter1-vals")
   testthat::expect_match(table_text, paste(statistics, collapse = "")) # the order is lost
-
-
-
-
-
+  # WILL IMPROVE THE ABOVE ONCE this is fixed: https://github.com/insightsengineering/teal.modules.general/issues/735
   app_driver$stop()
 })