does within break tests lol

insightsengineering · May 15, 2024 · 96b516d · 96b516d
1 parent df33240
commit 96b516d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/.github/workflows/check.yaml b/.github/workflows/check.yaml
@@ -13,6 +13,7 @@ on:
   push:
     branches:
       - main
+      - testing_tests@main
   workflow_dispatch:
 
 jobs:
@@ -50,7 +51,7 @@ jobs:
     with:
       additional-env-vars: |
         _R_CHECK_EXAMPLE_TIMING_THRESHOLD_=11
-        TESTING_DEPTH=5
+        TESTING_DEPTH=6
       enforce-note-blocklist: true
       publish-unit-test-report-gh-pages: false
       junit-xml-comparison: false

diff --git a/tests/testthat/helper-testing-depth.R b/tests/testthat/helper-testing-depth.R
@@ -41,7 +41,7 @@ get_testing_depth <- function() {
 #' By default `depth` argument lower or equal to 3 will not be skipped because by default `TESTING_DEPTH`
 #' is equal to 3. To skip <= 3 depth tests then the environment variable has to be lower than 3 respectively.
 skip_if_too_deep <- function(depth) { # nolintr
-  checkmate::assert_numeric(depth, len = 1, lower = 0, upper = 5)
+  checkmate::assert_numeric(depth, len = 1, lower = 0, upper = 6)
   testing_depth <- get_testing_depth() # by default 3 if there are no env variable
   if (testing_depth < depth) {
     testthat::skip(paste("testing depth", testing_depth, "is below current testing specification", depth))

diff --git a/tests/testthat/test-shinytest2-tm_front_page.R b/tests/testthat/test-shinytest2-tm_front_page.R
@@ -1,8 +1,8 @@
 app_driver_tm_front_page <- function() {
   data <- simple_cdisc_data()
-  data <- within(data, {
-    attr(ADSL, "metadata") <- list("Author" = "NEST team", "data_source" = "synthetic data")
-  })
+  # data <- within(data, {
+  #   attr(ADSL, "metadata") <- list("Author" = "NEST team", "data_source" = "synthetic data")
+  # })
 
   init_teal_app_driver(
     data = data,
@@ -22,7 +22,7 @@ app_driver_tm_front_page <- function() {
 }
 
 test_that("e2e - tm_front_page: Initializes without errors and check html elements", {
-  skip_if_too_deep(5)
+  skip_if_too_deep(6)
   app_driver <- app_driver_tm_front_page()
 
   app_driver$expect_no_shiny_error()