Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-release tm_g_distribution document update #669

Merged
merged 6 commits into from
Feb 27, 2024
Merged

pre-release tm_g_distribution document update #669

merged 6 commits into from
Feb 27, 2024

Conversation

kartikeyakirar
Copy link
Contributor

@kartikeyakirar kartikeyakirar commented Feb 22, 2024 •
edited
Loading

part of #624

@kartikeyakirar kartikeyakirar changed the base branch from main to pre-release@main February 22, 2024 09:36
@kartikeyakirar kartikeyakirar mentioned this pull request Feb 22, 2024
Closed
26 tasks
@github-actions GitHub Actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ----------------------------------------------
R/tm_a_pca.R                    826     826  0.00%    72-1022
R/tm_a_regression.R             716     716  0.00%    93-892
R/tm_data_table.R               177     177  0.00%    65-291
R/tm_file_viewer.R              172     172  0.00%    42-244
R/tm_front_page.R               129     118  8.53%    66-210
R/tm_g_association.R            332     332  0.00%    82-473
R/tm_g_bivariate.R              652     492  24.54%   128-703, 751, 757, 761, 872, 889, 907, 927-949
R/tm_g_distribution.R          1028    1028  0.00%    120-1272
R/tm_g_response.R               351     351  0.00%    88-503
R/tm_g_scatterplot.R            719     719  0.00%    160-970
R/tm_g_scatterplotmatrix.R      280     261  6.79%    80-377, 431, 445
R/tm_missing_data.R            1054    1054  0.00%    56-1249
R/tm_outliers.R                 976     976  0.00%    78-1184
R/tm_t_crosstable.R             254     254  0.00%    83-375
R/tm_variable_browser.R         820     815  0.61%    65-1293
R/utils.R                       119     119  0.00%    72-331
R/zzz.R                           1       1  0.00%    2
TOTAL                          8606    8411  2.27%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  --------
R/tm_g_bivariate.R       -3      -3  +0.11%
R/utils.R                -3      -3  +100.00%
TOTAL                    -6      -6  +0.00%

Results for commit: 0ac4909

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

Unit Tests Summary

 1 files   5 suites   0s ⏱️
16 tests 16 ✅ 0 💤 0 ❌
49 runs  49 ✅ 0 💤 0 ❌

Results for commit 0ac4909.

@kartikeyakirar
merge back from pre-release
9f68fc6 
Merge branch 'pre-release@main' into tm_g_distribution@pre-release@main

# Conflicts:
#	R/tm_g_distribution.R
#	man/tm_g_distribution.Rd
@vedhav vedhav assigned vedhav and unassigned vedhav Feb 26, 2024
@vedhav vedhav self-requested a review February 26, 2024 11:37
vedhav
vedhav reviewed Feb 26, 2024
View reviewed changes
R/tm_g_distribution.R Outdated Show resolved Hide resolved
@vedhav vedhav mentioned this pull request Feb 26, 2024
Merged
@vedhav vedhav self-assigned this Feb 26, 2024
vedhav
vedhav reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Else, LGTM.

R/tm_g_distribution.R Outdated Show resolved Hide resolved
vedhav
vedhav reviewed Feb 27, 2024
View reviewed changes
R/tm_g_distribution.R Outdated Show resolved Hide resolved
@vedhav vedhav mentioned this pull request Feb 27, 2024
Merged
kartikeyakirar and others added 2 commits February 27, 2024 12:59
@kartikeyakirar @vedhav
Update R/tm_g_distribution.R
e99fc12 
Co-authored-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar
@vedha sugguestion
db5ffdf
@vedhav vedhav self-requested a review February 27, 2024 08:01
vedhav
vedhav approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@kartikeyakirar kartikeyakirar merged commit 446ce56 into pre-release@main Feb 27, 2024
@kartikeyakirar kartikeyakirar deleted the tm_g_distribution@pre-release@main branch February 27, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m7pr m7pr m7pr left review comments

@vedhav vedhav vedhav approved these changes

Assignees

@vedhav vedhav

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kartikeyakirar @vedhav @m7pr