Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes popup dialog that keeps appearing when variable is changed on tm_outliers #693

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Feb 27, 2024

Pull Request

Fixes #648

Changes description

  • Prevents rendering the DT::dataTableOutput output tag multiple times (not the data table itself)
    • I believe when the re-rendering occurs, it tries to display the previous columns
    • Given that the data changed when variable is selected, previously available column is not found in the data

For the reviewer

  • Code to replicate the problem (and test the solution) can be found on the original issue

@averissimo averissimo force-pushed the 648-outliers-DT-bug@main branch from 402abcb to c68b947 Compare February 27, 2024 12:50
Copy link
Contributor

github-actions bot commented Feb 27, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  --------------------------------------
R/tm_a_pca.R                    825     825  0.00%    111-1060
R/tm_a_regression.R             777     777  0.00%    153-1034
R/tm_data_table.R               177     177  0.00%    91-317
R/tm_file_viewer.R              172     172  0.00%    42-244
R/tm_front_page.R               129     118  8.53%    66-210
R/tm_g_association.R            332     332  0.00%    130-521
R/tm_g_bivariate.R              665     493  25.86%   192-773, 836, 947, 964, 982, 1002-1024
R/tm_g_distribution.R          1028    1028  0.00%    121-1271
R/tm_g_response.R               351     351  0.00%    139-554
R/tm_g_scatterplot.R            719     719  0.00%    236-1046
R/tm_g_scatterplotmatrix.R      280     261  6.79%    163-460, 514, 528
R/tm_missing_data.R            1054    1054  0.00%    87-1280
R/tm_outliers.R                 977     977  0.00%    132-1240
R/tm_t_crosstable.R             254     254  0.00%    134-426
R/tm_variable_browser.R         820     815  0.61%    86-1314
R/utils.R                       100     100  0.00%    72-300
R/zzz.R                           1       1  0.00%    2
TOTAL                          8661    8454  2.39%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  --------
R/tm_outliers.R       +1      +1  +100.00%
TOTAL                 +1      +1  -0.00%

Results for commit: a4ce619

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Feb 27, 2024

Unit Tests Summary

 1 files   5 suites   0s ⏱️
16 tests 16 ✅ 0 💤 0 ❌
49 runs  49 ✅ 0 💤 0 ❌

Results for commit a4ce619.

♻️ This comment has been updated with latest results.

@gogonzo gogonzo self-assigned this Feb 28, 2024
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@averissimo averissimo enabled auto-merge (squash) February 28, 2024 13:36
@averissimo averissimo merged commit ff008a3 into main Feb 28, 2024
24 checks passed
@averissimo averissimo deleted the 648-outliers-DT-bug@main branch February 28, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in tm_outliers
2 participants