Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

712 - {shinytest2} for tm_data_table #719

Merged
merged 33 commits into from
Apr 19, 2024
Merged

Conversation

kartikeyakirar
Copy link
Contributor

@kartikeyakirar kartikeyakirar commented Apr 11, 2024

Part of #712

- [ ] testing table caption (DT functionality)

  • testing table
  • variable selected

@kartikeyakirar kartikeyakirar marked this pull request as draft April 11, 2024 12:10
@kartikeyakirar kartikeyakirar marked this pull request as ready for review April 11, 2024 14:05
Copy link
Contributor

github-actions bot commented Apr 11, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    833     833  0.00%    108-1074
R/tm_a_regression.R             779     779  0.00%    153-1037
R/tm_data_table.R               184     184  0.00%    93-330
R/tm_file_viewer.R              172     172  0.00%    44-250
R/tm_front_page.R               132     121  8.33%    70-226
R/tm_g_association.R            336     336  0.00%    135-543
R/tm_g_bivariate.R              674     412  38.87%   308-775, 816, 927, 944, 962, 973-995
R/tm_g_distribution.R          1056    1056  0.00%    122-1317
R/tm_g_response.R               352     352  0.00%    154-579
R/tm_g_scatterplot.R            728     728  0.00%    230-1059
R/tm_g_scatterplotmatrix.R      284     265  6.69%    165-478, 539, 553
R/tm_missing_data.R            1063    1063  0.00%    92-1311
R/tm_outliers.R                 991     991  0.00%    134-1269
R/tm_t_crosstable.R             257     257  0.00%    141-446
R/tm_variable_browser.R         829     824  0.60%    79-1069, 1107-1291
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8771    8471  3.42%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: c76d5b7

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Unit Tests Summary

  1 files   15 suites   5m 42s ⏱️
 76 tests  76 ✅ 0 💤 0 ❌
272 runs  272 ✅ 0 💤 0 ❌

Results for commit c76d5b7.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_data_table 👶 $+17.11$ $+10$ $0$ $0$ $0$
shinytest2-tm_g_scatterplot 💔 $71.77$ $+1.33$ $0$ $0$ $0$ $0$
shinytest2-tm_outliers 💔 $81.67$ $+1.70$ $0$ $0$ $0$ $0$
shinytest2-tm_variable_browser 💔 $46.18$ $+1.92$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_data_table 👶 $+3.85$ e2e_tm_data_table_Initializes_without_errors
shinytest2-tm_data_table 👶 $+3.93$ e2e_tm_data_table_Verify_checkbox_displayed_over_data_table
shinytest2-tm_data_table 👶 $+4.56$ e2e_tm_data_table_Verify_default_variable_selection_and_set_new_selection
shinytest2-tm_data_table 👶 $+4.77$ e2e_tm_data_table_Verify_module_displays_data_table
shinytest2-tm_variable_browser 💔 $7.73$ $+1.18$ e2e_tm_variable_browser_Selecting_treat_variable_as_factor_changes_the_table_headers

Results for commit 35876a7

♻️ This comment has been updated with latest results.

@averissimo averissimo mentioned this pull request Apr 12, 2024
19 tasks
@m7pr m7pr self-assigned this Apr 15, 2024
@m7pr
Copy link
Contributor

m7pr commented Apr 16, 2024

@kartikeyakirar I left you 3 comments

kartikeyakirar and others added 4 commits April 16, 2024 18:34
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@m7pr m7pr added the core label Apr 16, 2024
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kartikeyakirar I added one more test for distinction verification and extended the one that compares tables. This is great job. Nice test on table values

kartikeyakirar and others added 4 commits April 19, 2024 16:30
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar kartikeyakirar enabled auto-merge (squash) April 19, 2024 11:17
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
@kartikeyakirar kartikeyakirar disabled auto-merge April 19, 2024 11:24
@kartikeyakirar kartikeyakirar enabled auto-merge (squash) April 19, 2024 11:26
@kartikeyakirar
Copy link
Contributor Author

@m7pr there is error on distinct row check . fixed it here 391902e

@kartikeyakirar kartikeyakirar merged commit 7857ad6 into main Apr 19, 2024
23 of 24 checks passed
@kartikeyakirar kartikeyakirar deleted the 712-tm_data_table@main branch April 19, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants