Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

712 - {shinytest2} for tm_g_response #725

Merged
merged 21 commits into from
Apr 22, 2024
Merged

712 - {shinytest2} for tm_g_response #725

merged 21 commits into from
Apr 22, 2024

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Apr 12, 2024

Part of #712

@vedhav vedhav mentioned this pull request Apr 12, 2024
Closed
19 tasks
@vedhav vedhav marked this pull request as ready for review April 15, 2024 09:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    833     833  0.00%    108-1074
R/tm_a_regression.R             779     779  0.00%    153-1037
R/tm_data_table.R               184     184  0.00%    93-330
R/tm_file_viewer.R              172     172  0.00%    44-250
R/tm_front_page.R               132     121  8.33%    70-226
R/tm_g_association.R            336     336  0.00%    135-543
R/tm_g_bivariate.R              678     416  38.64%   303-775, 816, 927, 944, 962, 973-995
R/tm_g_distribution.R          1056    1056  0.00%    122-1317
R/tm_g_response.R               357     357  0.00%    154-584
R/tm_g_scatterplot.R            728     728  0.00%    230-1059
R/tm_g_scatterplotmatrix.R      284     265  6.69%    165-478, 539, 553
R/tm_missing_data.R            1075    1075  0.00%    92-1323
R/tm_outliers.R                 991     991  0.00%    134-1269
R/tm_t_crosstable.R             257     257  0.00%    141-446
R/tm_variable_browser.R         829     824  0.60%    79-1069, 1107-1291
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8792    8492  3.41%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  --------
R/tm_g_response.R       +5      +5  +100.00%
TOTAL                   +5      +5  -0.00%

Results for commit: 834ab45

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2024 •
edited
Loading

Unit Tests Summary

  1 files   21 suites   10m 34s ⏱️
107 tests 107 ✅ 0 💤 0 ❌
435 runs  435 ✅ 0 💤 0 ❌

Results for commit 834ab45.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2024 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_g_response 👶 $+28.16$ $+17$ $0$ $0$ $0$
shinytest2-tm_g_scatterplot 💔 $73.30$ $+1.62$ $0$ $0$ $0$ $0$
shinytest2-tm_variable_browser 💔 $47.98$ $+1.02$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_g_response 👶 $+5.46$ e2e_tm_g_response_deselecting_response_produces_validation_error
shinytest2-tm_g_response 👶 $+5.63$ e2e_tm_g_response_deselecting_x_produces_validation_error
shinytest2-tm_g_response 👶 $+11.51$ e2e_tm_g_response_encoding_inputs_produce_output_without_validation_errors
shinytest2-tm_g_response 👶 $+5.55$ e2e_tm_g_response_module_is_initialised_with_the_specified_defaults

Results for commit 40f89e4

♻️ This comment has been updated with latest results.

@m7pr m7pr added the core label Apr 16, 2024
m7pr
m7pr previously requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename set_module_input to set_active_module_input

tests/testthat/test-shinytest2-tm_g_response.R Outdated Show resolved Hide resolved
averissimo and others added 4 commits April 17, 2024 10:46
@averissimo
Merge branch 'main' into 712-tm_g_response@main
cdbc5f9
@averissimo @m7pr
Apply suggestions from @m7pr on set_active_module_input rename
991507e 
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
@averissimo
chore: revert prefix of ggplot2
3a92d00
@averissimo
fix: replace TealAppDriver with init_teal_app_driver
81f1ed5
@averissimo averissimo dismissed m7pr’s stale review April 19, 2024 12:28

Changes applied

@vedhav vedhav enabled auto-merge (squash) April 22, 2024 12:51
@vedhav vedhav merged commit 6618bb6 into main Apr 22, 2024
21 checks passed
@vedhav vedhav deleted the 712-tm_g_response@main branch April 22, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averissimo averissimo averissimo left review comments

@gogonzo gogonzo gogonzo approved these changes

@m7pr m7pr m7pr left review comments

Assignees

@gogonzo gogonzo

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vedhav @averissimo @gogonzo @m7pr