Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

712 - {shinytest2} for tm_g_distribution #726

Merged
merged 16 commits into from
Apr 19, 2024
Merged

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Apr 12, 2024

Part of #712

@vedhav vedhav mentioned this pull request Apr 12, 2024
19 tasks
@vedhav vedhav marked this pull request as ready for review April 15, 2024 09:45
Copy link
Contributor

github-actions bot commented Apr 15, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    833     833  0.00%    108-1074
R/tm_a_regression.R             779     779  0.00%    153-1037
R/tm_data_table.R               184     184  0.00%    93-330
R/tm_file_viewer.R              172     172  0.00%    44-250
R/tm_front_page.R               132     121  8.33%    70-226
R/tm_g_association.R            336     336  0.00%    135-543
R/tm_g_bivariate.R              678     416  38.64%   303-775, 816, 927, 944, 962, 973-995
R/tm_g_distribution.R          1056    1056  0.00%    122-1317
R/tm_g_response.R               352     352  0.00%    154-579
R/tm_g_scatterplot.R            728     728  0.00%    230-1059
R/tm_g_scatterplotmatrix.R      284     265  6.69%    165-478, 539, 553
R/tm_missing_data.R            1063    1063  0.00%    92-1311
R/tm_outliers.R                 991     991  0.00%    134-1269
R/tm_t_crosstable.R             257     257  0.00%    141-446
R/tm_variable_browser.R         829     824  0.60%    79-1069, 1107-1291
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8775    8475  3.42%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 6f73112

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Apr 15, 2024

Unit Tests Summary

  1 files   17 suites   7m 27s ⏱️
 83 tests  83 ✅ 0 💤 0 ❌
337 runs  337 ✅ 0 💤 0 ❌

Results for commit 6f73112.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 15, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_regression 💔 $41.60$ $+1.08$ $0$ $0$ $0$ $0$
shinytest2-tm_g_distribution 👶 $+55.84$ $+21$ $0$ $0$ $0$
shinytest2-tm_g_scatterplot 💚 $98.21$ $-25.01$ $0$ $0$ $0$ $0$
shinytest2-tm_outliers 💔 $83.40$ $+2.86$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_g_distribution 👶 $+14.59$ e2e_tm_g_distribution_histogram_encoding_inputs_produce_output_without_validation_errors
shinytest2-tm_g_distribution 👶 $+32.14$ e2e_tm_g_distribution_module_is_initialised_with_the_specified_defaults
shinytest2-tm_g_distribution 👶 $+9.11$ e2e_tm_g_distribution_qqplot_encoding_inputs_produce_output_without_validation_errors
shinytest2-tm_g_scatterplot 💚 $31.91$ $-25.72$ e2e_tm_g_scatterplot_module_is_initialised_with_the_specified_defaults

Results for commit 6047c05

♻️ This comment has been updated with latest results.

@averissimo averissimo self-assigned this Apr 15, 2024
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you testing the data_extract_vars here?

tests/testthat/test-shinytest2-tm_g_distribution.R Outdated Show resolved Hide resolved
@m7pr m7pr added the core label Apr 16, 2024
m7pr
m7pr previously requested changes Apr 16, 2024
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename set_module_input to set_active_module_input

tests/testthat/test-shinytest2-tm_g_distribution.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-tm_g_distribution.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-tm_g_distribution.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-tm_g_distribution.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-tm_g_distribution.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-tm_g_distribution.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-tm_g_distribution.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-tm_g_distribution.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-tm_g_distribution.R Outdated Show resolved Hide resolved
tests/testthat/test-shinytest2-tm_g_distribution.R Outdated Show resolved Hide resolved
averissimo and others added 4 commits April 17, 2024 10:49
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look good, it fails as there is still one error lingering from the start of the app,

As no test has been selected during "e2e - tm_g_distribution: module is initialised with the specified defaults", {"

@averissimo averissimo dismissed m7pr’s stale review April 19, 2024 12:04

changes applied

Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@averissimo averissimo enabled auto-merge (squash) April 19, 2024 12:23
auto-merge was automatically disabled April 19, 2024 12:36

Base branch was modified

@averissimo averissimo enabled auto-merge (squash) April 19, 2024 12:37
@averissimo averissimo merged commit f793c64 into main Apr 19, 2024
20 checks passed
@averissimo averissimo deleted the 712-tm_g_distribution@main branch April 19, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants