-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
712 - {shinytest2}
for tm_g_distribution
#726
Conversation
Code Coverage Summary
Diff against main
Results for commit: 6f73112 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 17 suites 7m 27s ⏱️ Results for commit 6f73112. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 6047c05 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you testing the data_extract_vars
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename set_module_input
to set_active_module_input
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com> Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests look good, it fails as there is still one error lingering from the start of the app,
As no test has been selected during "e2e - tm_g_distribution: module is initialised with the specified defaults", {"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Base branch was modified
Part of #712