Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

712 - {shinytest2} for tm_g_scatterplotmatrix #734

Merged
merged 25 commits into from
Apr 19, 2024
Merged

712 - {shinytest2} for tm_g_scatterplotmatrix #734

merged 25 commits into from
Apr 19, 2024

Conversation

kartikeyakirar
Copy link
Contributor

Part of #712

@kartikeyakirar kartikeyakirar marked this pull request as draft April 17, 2024 06:32
@kartikeyakirar kartikeyakirar mentioned this pull request Apr 17, 2024
Closed
19 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    833     833  0.00%    108-1074
R/tm_a_regression.R             779     779  0.00%    153-1037
R/tm_data_table.R               184     184  0.00%    93-330
R/tm_file_viewer.R              172     172  0.00%    44-250
R/tm_front_page.R               132     121  8.33%    70-226
R/tm_g_association.R            336     336  0.00%    135-543
R/tm_g_bivariate.R              674     412  38.87%   308-775, 816, 927, 944, 962, 973-995
R/tm_g_distribution.R          1056    1056  0.00%    122-1317
R/tm_g_response.R               352     352  0.00%    154-579
R/tm_g_scatterplot.R            728     728  0.00%    230-1059
R/tm_g_scatterplotmatrix.R      284     265  6.69%    165-478, 539, 553
R/tm_missing_data.R            1063    1063  0.00%    92-1311
R/tm_outliers.R                 991     991  0.00%    134-1269
R/tm_t_crosstable.R             257     257  0.00%    141-446
R/tm_variable_browser.R         829     824  0.60%    79-1069, 1107-1291
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8771    8471  3.42%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 199d865

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_g_scatterplotmatrix 👶 $+21.60$ $+9$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_g_scatterplotmatrix 👶 $+6.45$ e2e_tm_g_scatterplotmatrix_Change_plot_settings
shinytest2-tm_g_scatterplotmatrix 👶 $+4.57$ e2e_tm_g_scatterplotmatrix_Initializes_without_errors
shinytest2-tm_g_scatterplotmatrix 👶 $+5.88$ e2e_tm_g_scatterplotmatrix_Verify_default_values_and_settings_data_extracts_for_data_selection
shinytest2-tm_g_scatterplotmatrix 👶 $+4.70$ e2e_tm_g_scatterplotmatrix_Verify_module_displays_data_table

Results for commit 21eddc7

♻️ This comment has been updated with latest results.

@kartikeyakirar kartikeyakirar marked this pull request as ready for review April 17, 2024 09:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024 •
edited
Loading

Unit Tests Summary

  1 files   10 suites   3m 0s ⏱️
 53 tests  53 ✅ 0 💤 0 ❌
174 runs  174 ✅ 0 💤 0 ❌

Results for commit 199d865.

♻️ This comment has been updated with latest results.

kartikeyakirar and others added 6 commits April 17, 2024 15:29
@kartikeyakirar
fix linter issue
59cb826
@github-actions
[skip style] [skip vbump] Restyle files
8e003e2
@averissimo
chore: trigger ci
03f5eae
@kartikeyakirar
fix the app_driver issue.
66fe399
@kartikeyakirar
merge back
4ee07f7 
Merge branch '712_tm_g_scatterplotmatrix@main' of https://github.com/insightsengineering/teal.modules.general into 712_tm_g_scatterplotmatrix@main

# Conflicts:
#	tests/testthat/test-shinytest2-tm_g_scatterplotmatrix.R
@github-actions
[skip style] [skip vbump] Restyle files
9ec3415
m7pr
m7pr approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left only few suggestions (prefixing) for you to accept

kartikeyakirar and others added 10 commits April 18, 2024 18:29
@kartikeyakirar @m7pr
Update tests/testthat/test-shinytest2-tm_g_scatterplotmatrix.R
12c4615 
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar @m7pr
Update tests/testthat/test-shinytest2-tm_g_scatterplotmatrix.R
be0c590 
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar @m7pr
Update tests/testthat/test-shinytest2-tm_g_scatterplotmatrix.R
1e68510 
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar @m7pr
Update tests/testthat/test-shinytest2-tm_g_scatterplotmatrix.R
892ee44 
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar @m7pr
Update tests/testthat/test-shinytest2-tm_g_scatterplotmatrix.R
747016b 
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar @m7pr
Update tests/testthat/test-shinytest2-tm_g_scatterplotmatrix.R
4b49312 
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar @m7pr
Update tests/testthat/test-shinytest2-tm_g_scatterplotmatrix.R
5f80378 
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar @m7pr
Update tests/testthat/test-shinytest2-tm_g_scatterplotmatrix.R
47ed1dd 
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar @m7pr
Update tests/testthat/test-shinytest2-tm_g_scatterplotmatrix.R
527280f 
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar @m7pr
Update tests/testthat/test-shinytest2-tm_g_scatterplotmatrix.R
b0d2d4e 
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar kartikeyakirar enabled auto-merge (squash) April 18, 2024 14:20
@kartikeyakirar kartikeyakirar merged commit 57ab2de into main Apr 19, 2024
21 checks passed
@kartikeyakirar kartikeyakirar deleted the 712_tm_g_scatterplotmatrix@main branch April 19, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m7pr m7pr m7pr approved these changes

Assignees

@m7pr m7pr

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kartikeyakirar @m7pr @averissimo