Improvement on decorators #822

averissimo · 2025-01-06T14:33:57Z

Pull Request

Fixes https://github.com/insightsengineering/coredev-tasks/issues/605

Changes description

Use updated utils.R functions
Source code standardization (avoids repeated complex call to reactive)
Update documentation
~~Revert ggplot2_args to roxygen2 @template~~
- I think we should keep this as is, it is the recommended way by roxygen2 documentation.
Revisit {lifecycle} dependency
Remove decorators that are not present in report

Modules that need recheck (for reviewer):

tm_data_table: decorators removed
tm_missing_data: Decorators using rlisting instead of DataTable
tm_distribution: Was decorating data.frames in report, moved to rlisting
tm_outliers: Code improvement

Big example app

pkgload::load_all(".")

# ######################################################
#
#   _____                           _
#  |  __ \                         | |
#  | |  | | ___  ___ ___  _ __ __ _| |_ ___  _ __ ___
#  | |  | |/ _ \/ __/ _ \| '__/ _` | __/ _ \| '__/ __|
#  | |__| |  __/ (_| (_) | | | (_| | || (_) | |  \__ \
#  |_____/ \___|\___\___/|_|  \__,_|\__\___/|_|  |___/
#
#
#
#  Decorators
# #####################################################

plot_grob_decorator <- function(default_footnote = "I am a good decorator", .var_to_replace = "plot") {
  teal_transform_module(
    label = "Caption (grob)",
    ui = function(id) shiny::textInput(shiny::NS(id, "footnote"), "Footnote", value = default_footnote),
    server = function(id, data) {
      moduleServer(id, function(input, output, session) {
        logger::log_info("🟠 plot_grob with default: {default_footnote}!", namespace = "teal.modules.general")
        reactive({
          req(data(), input$footnote)
          logger::log_info("changing the footnote {default_footnote}", namespace = "teal.modules.general")
          teal.code::eval_code(data(), substitute(
            {
              footnote_grob <- grid::textGrob(footnote, x = 0, hjust = 0, gp = grid::gpar(fontsize = 10, fontface = "italic", col = "gray50"))
              # Arrange the plot and footnote
              .var_to_replace <- gridExtra::arrangeGrob(
                .var_to_replace,
                footnote_grob,
                ncol = 1,
                heights = grid::unit.c(grid::unit(1, "npc") - grid::unit(1, "lines"), grid::unit(1, "lines"))
              )
            },
            env = list(
              footnote = input$footnote,
              .var_to_replace = as.name(.var_to_replace)
            )))
        })
      })
    }
  )
}
caption_decorator <- function(default_caption = "I am a good decorator", .var_to_replace = "plot") {
  teal_transform_module(
    label = "Caption",
    ui = function(id) shiny::textInput(shiny::NS(id, "footnote"), "Footnote", value = default_caption),
    server = make_teal_transform_server(
      substitute({
        my_name <- .var_name
        .var_to_replace <- .var_to_replace + ggplot2::labs(caption = footnote)
      }, env = list(.var_to_replace = as.name(.var_to_replace), .var_name = .var_to_replace))
    )
  )
}

treelis_subtitle_decorator <- function(default_caption = "I am a good decorator", .var_to_replace = "plot") {
  teal_transform_module(
    label = "Caption",
    ui = function(id) shiny::textInput(shiny::NS(id, "footnote"), "Footnote", value = default_caption),
    server = make_teal_transform_server(
      substitute({
        .var_to_replace <- update(.var_to_replace, sub = footnote)
      }, env = list(.var_to_replace = as.name(.var_to_replace)))
    )
  )
}

insert_rrow_decorator <- function(default_caption = "I am a good new row", .var_to_replace = "table") {
  teal_transform_module(
    label = "New row",
    ui = function(id) shiny::textInput(shiny::NS(id, "new_row"), "New row", value = default_caption),
    server = make_teal_transform_server(
      substitute({
        .var_to_replace <- rtables::insert_rrow(.var_to_replace, rtables::rrow(new_row))
      }, env = list(.var_to_replace = as.name(.var_to_replace)))
    )
  )
}

rlisting_decorator <- function(default_caption = "I am a good new row", .var_to_replace = "table") {
  teal_transform_module(
    label = "New row",
    ui = function(id) shiny::textInput(shiny::NS(id, "new_row"), "New row", value = default_caption),
    server = make_teal_transform_server(
      substitute({
        rlistings::main_title(.var_to_replace) <- new_row
      }, env = list(.var_to_replace = as.name(.var_to_replace)))
    )
  )
}
do_nothing_decorator <- teal_transform_module(server = function(id, data) moduleServer(id, function(input, output, session) data))

# ##########################################
#
#   _             _      _       _
#  | |           | |    | |     | |
#  | |_ ___  __ _| |  __| | __ _| |_ __ _
#  | __/ _ \/ _` | | / _` |/ _` | __/ _` |
#  | ||  __/ (_| | || (_| | (_| | || (_| |
#   \__\___|\__,_|_| \__,_|\__,_|\__\__,_|
#                ______
#               |______|
#
#  teal_data
# #########################################

data <- teal_data(join_keys = default_cdisc_join_keys[c("ADSL", "ADRS")])
data <- within(data, {
  require(nestcolor)
  ADSL <- rADSL
  ADRS <- rADRS
})

# For tm_outliers
fact_vars_adsl <- names(Filter(isTRUE, sapply(data[["ADSL"]], is.factor)))
vars <- choices_selected(variable_choices(data[["ADSL"]], fact_vars_adsl))

# For tm_g_distribution

vars1 <- choices_selected(
  variable_choices(data[["ADSL"]], c("ARM", "COUNTRY", "SEX")),
  selected = NULL
)


init(
  data = data,
  modules = modules(
    # ###################################################
    #
    #                                    _
    #                                   (_)
    #   _ __ ___  __ _ _ __ ___  ___ ___ _  ___  _ __
    #  | '__/ _ \/ _` | '__/ _ \/ __/ __| |/ _ \| '_ \
    #  | | |  __/ (_| | | |  __/\__ \__ \ | (_) | | | |
    #  |_|  \___|\__, |_|  \___||___/___/_|\___/|_| |_|
    #             __/ |
    #            |___/
    #
    #  regression
    # ##################################################
    tm_a_regression(
      label = "Regression",
      response = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(
          label = "Select variable:",
          choices = "BMRKR1",
          selected = "BMRKR1",
          multiple = FALSE,
          fixed = TRUE
        )
      ),
      regressor = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(
          label = "Select variables:",
          choices = variable_choices(data[["ADSL"]], c("AGE", "SEX", "RACE")),
          selected = "AGE",
          multiple = TRUE,
          fixed = FALSE
        )
      ),
      decorators = list(caption_decorator("I am Regression", "plot"))
    ),
    # #########################################################
    #
    #       _ _     _        _ _           _   _
    #      | (_)   | |      (_) |         | | (_)
    #    __| |_ ___| |_ _ __ _| |__  _   _| |_ _  ___  _ __
    #   / _` | / __| __| '__| | '_ \| | | | __| |/ _ \| '_ \
    #  | (_| | \__ \ |_| |  | | |_) | |_| | |_| | (_) | | | |
    #   \__,_|_|___/\__|_|  |_|_.__/ \__,_|\__|_|\___/|_| |_|
    #
    #
    #
    #  distribution
    # ########################################################
    tm_g_distribution(
      dist_var = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(
          choices = variable_choices(data[["ADSL"]], c("AGE", "BMRKR1")),
          selected = "BMRKR1",
          multiple = FALSE,
          fixed = FALSE
        )
      ),
      strata_var = data_extract_spec(
        dataname = "ADSL",
        filter = filter_spec(
          vars = vars1,
          multiple = TRUE
        )
      ),
      group_var = data_extract_spec(
        dataname = "ADSL",
        filter = filter_spec(
          vars = vars1,
          multiple = TRUE
        )
      ),
      decorators = list(
        histogram_plot = caption_decorator("I am density!", "histogram_plot"),
        qq_plot = caption_decorator("I am QQ!", "qq_plot"),
        summary_table = rlisting_decorator("summary row", "summary_table"),
        test_table = rlisting_decorator("test row", "test_table")
      )
    ),
    # ####################
    #
    #
    #
    #   _ __   ___ __ _
    #  | '_ \ / __/ _` |
    #  | |_) | (_| (_| |
    #  | .__/ \___\__,_|
    #  | |
    #  |_|
    #
    #  pca
    # ###################
    tm_a_pca(
      "PCA",
      dat = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(
          choices = variable_choices(data = data[["ADSL"]], c("BMRKR1", "AGE", "EOSDY")),
          selected = c("BMRKR1", "AGE")
        )
      ),
      decorators = list(
        elbow_plot = caption_decorator("I am PCA / elbow", "elbow_plot"),
        circle_plot = caption_decorator("I am a PCA / circle", "circle_plot"),
        biplot = caption_decorator("I am a PCA / bipot", "biplot"),
        eigenvector_plot = caption_decorator("I am a PCA / eigenvector", "eigenvector_plot")
      )
    ),
    ######################################
    #
    #               _   _ _
    #              | | | (_)
    #    ___  _   _| |_| |_  ___ _ __ ___
    #   / _ \| | | | __| | |/ _ \ '__/ __|
    #  | (_) | |_| | |_| | |  __/ |  \__ \
    #   \___/ \__,_|\__|_|_|\___|_|  |___/
    #
    #
    #
    #  outliers
    # #####################################
    tm_outliers(
      outlier_var = list(
        data_extract_spec(
          dataname = "ADSL",
          select = select_spec(
            label = "Select variable:",
            choices = variable_choices(data[["ADSL"]], c("AGE", "BMRKR1")),
            selected = "AGE",
            multiple = FALSE,
            fixed = FALSE
          )
        )
      ),
      categorical_var = list(
        data_extract_spec(
          dataname = "ADSL",
          filter = filter_spec(
            vars = vars,
            choices = value_choices(data[["ADSL"]], vars$selected),
            selected = value_choices(data[["ADSL"]], vars$selected),
            multiple = TRUE
          )
        )
      ),
      decorators = list(
        box_plot = caption_decorator("I am a good decorator", "box_plot"),
        density_plot = caption_decorator("I am a good decorator", "density_plot"),
        cumulative_plot = caption_decorator("I am a good decorator", "cumulative_plot"),
        table = rlisting_decorator("table row", "table")
      )
    ),
    # #######################################################
    #
    #                            _       _   _
    #                           (_)     | | (_)
    #    __ _ ___ ___  ___   ___ _  __ _| |_ _  ___  _ __
    #   / _` / __/ __|/ _ \ / __| |/ _` | __| |/ _ \| '_ \
    #  | (_| \__ \__ \ (_) | (__| | (_| | |_| | (_) | | | |
    #   \__,_|___/___/\___/ \___|_|\__,_|\__|_|\___/|_| |_|
    #
    #
    #
    #  association
    # ######################################################
    tm_g_association(
      ref = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(
          choices = variable_choices(
            data[["ADSL"]],
            c("SEX", "RACE", "COUNTRY", "ARM", "STRATA1", "STRATA2", "ITTFL", "BMRKR2")
          ),
          selected = "RACE"
        )
      ),
      vars = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(
          choices = variable_choices(
            data[["ADSL"]],
            c("SEX", "RACE", "COUNTRY", "ARM", "STRATA1", "STRATA2", "ITTFL", "BMRKR2")
          ),
          selected = "BMRKR2",
          multiple = TRUE
        )
      ),
      decorators = list(plot_grob_decorator("I am a good grob (association)"))
    ),
    # ########################################################
    #
    #                                 _        _     _
    #                                | |      | |   | |
    #    ___ _ __ ___  ___ ___ ______| |_ __ _| |__ | | ___
    #   / __| '__/ _ \/ __/ __|______| __/ _` | '_ \| |/ _ \
    #  | (__| | | (_) \__ \__ \      | || (_| | |_) | |  __/
    #   \___|_|  \___/|___/___/       \__\__,_|_.__/|_|\___|
    #
    #
    #
    #  cross-table
    # #######################################################
    tm_t_crosstable(
      label = "Cross Table",
      x = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(
          choices = variable_choices(data[["ADSL"]], subset = function(data) {
            idx <- !vapply(data, inherits, logical(1), c("Date", "POSIXct", "POSIXlt"))
            return(names(data)[idx])
          }),
          selected = "COUNTRY",
          multiple = TRUE,
          ordered = TRUE
        )
      ),
      y = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(
          choices = variable_choices(data[["ADSL"]], subset = function(data) {
            idx <- vapply(data, is.factor, logical(1))
            return(names(data)[idx])
          }),
          selected = "SEX"
        )
      ),
      decorators = list(insert_rrow_decorator("I am a good new row"))
    ),
    # #######################################################################################
    #
    #                 _   _                  _       _                     _        _
    #                | | | |                | |     | |                   | |      (_)
    #   ___  ___ __ _| |_| |_ ___ _ __ _ __ | | ___ | |_   _ __ ___   __ _| |_ _ __ ___  __
    #  / __|/ __/ _` | __| __/ _ \ '__| '_ \| |/ _ \| __| | '_ ` _ \ / _` | __| '__| \ \/ /
    #  \__ \ (_| (_| | |_| ||  __/ |  | |_) | | (_) | |_  | | | | | | (_| | |_| |  | |>  <
    #  |___/\___\__,_|\__|\__\___|_|  | .__/|_|\___/ \__| |_| |_| |_|\__,_|\__|_|  |_/_/\_\
    #                                 | |
    #                                 |_|
    #
    #  scatterplot matrix
    # ######################################################################################
    tm_g_scatterplotmatrix(
      label = "Scatterplot matrix",
      variables = list(
        data_extract_spec(
          dataname = "ADSL",
          select = select_spec(
            choices = variable_choices(data[["ADSL"]]),
            selected = c("AGE", "RACE", "SEX"),
            multiple = TRUE,
            ordered = TRUE
          )
        ),
        data_extract_spec(
          dataname = "ADRS",
          filter = filter_spec(
            label = "Select endpoints:",
            vars = c("PARAMCD", "AVISIT"),
            choices = value_choices(data[["ADRS"]], c("PARAMCD", "AVISIT"), c("PARAM", "AVISIT")),
            selected = "INVET - END OF INDUCTION",
            multiple = TRUE
          ),
          select = select_spec(
            choices = variable_choices(data[["ADRS"]]),
            selected = c("AGE", "AVAL", "ADY"),
            multiple = TRUE,
            ordered = TRUE
          )
        )
      ),
      decorators = list(treelis_subtitle_decorator("I am a Scatterplot matrix", "plot"))
    ),
    # #############################################
    #
    #
    #
    #   _ __ ___  ___ _ __   ___  _ __  ___  ___
    #  | '__/ _ \/ __| '_ \ / _ \| '_ \/ __|/ _ \
    #  | | |  __/\__ \ |_) | (_) | | | \__ \  __/
    #  |_|  \___||___/ .__/ \___/|_| |_|___/\___|
    #                | |
    #                |_|
    #
    #  response
    # ############################################
    tm_g_response(
      label = "Response",
      response = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(choices = variable_choices(data[["ADSL"]], c("BMRKR2", "COUNTRY")))
      ),
      x = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(choices = variable_choices(data[["ADSL"]], c("SEX", "RACE")), selected = "RACE")
      ),
      decorators = list(caption_decorator("I am a Response", "plot"))
    ),
    # ############################################
    #
    #   _     _                 _       _
    #  | |   (_)               (_)     | |
    #  | |__  ___   ____ _ _ __ _  __ _| |_ ___
    #  | '_ \| \ \ / / _` | '__| |/ _` | __/ _ \
    #  | |_) | |\ V / (_| | |  | | (_| | ||  __/
    #  |_.__/|_| \_/ \__,_|_|  |_|\__,_|\__\___|
    #
    #
    #
    #  bivariate
    # ###########################################
    tm_g_bivariate(
      x = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(choices = variable_choices(data[["ADSL"]]), selected = "AGE")
      ),
      y = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(choices = variable_choices(data[["ADSL"]]), selected = "SEX")
      ),
      row_facet = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(choices = variable_choices(data[["ADSL"]]), selected = "ARM")
      ),
      col_facet = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(choices = variable_choices(data[["ADSL"]]), selected = "COUNTRY")
      ),
      decorators = list(caption_decorator("I am a Bivariate", "plot"))
    ),
    #####################################################
    #
    #                 _   _                  _       _
    #                | | | |                | |     | |
    #   ___  ___ __ _| |_| |_ ___ _ __ _ __ | | ___ | |_
    #  / __|/ __/ _` | __| __/ _ \ '__| '_ \| |/ _ \| __|
    #  \__ \ (_| (_| | |_| ||  __/ |  | |_) | | (_) | |_
    #  |___/\___\__,_|\__|\__\___|_|  | .__/|_|\___/ \__|
    #                                 | |
    #                                 |_|
    #
    #  scatterplot
    # ####################################################
    tm_g_scatterplot(
      label = "Scatterplot",
      x = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(choices = variable_choices(data[["ADSL"]], c("AGE", "BMRKR1", "BMRKR2")))
      ),
      y = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(
          choices = variable_choices(data[["ADSL"]], c("AGE", "BMRKR1", "BMRKR2")),
          selected = "BMRKR1"
        )
      ),
      color_by = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(
          choices = variable_choices(data[["ADSL"]], c("AGE", "BMRKR1", "BMRKR2", "RACE", "REGION1")),
          selected = NULL
        )
      ),
      size_by = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(choices = variable_choices(data[["ADSL"]], c("AGE", "BMRKR1")))
      ),
      row_facet = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(
          choices = variable_choices(data[["ADSL"]], c("BMRKR2", "RACE", "REGION1")),
          selected = NULL
        )
      ),
      col_facet = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(
          choices = variable_choices(data[["ADSL"]], c("BMRKR2", "RACE", "REGION1")),
          selected = NULL
        )
      ),
      decorators = list(caption_decorator("I am a scatterplot", "plot"))
    ),
    # ##############################################################
    #
    #             _         _                    _       _
    #            (_)       (_)                  | |     | |
    #   _ __ ___  _ ___ ___ _ _ __   __ _     __| | __ _| |_ __ _
    #  | '_ ` _ \| / __/ __| | '_ \ / _` |   / _` |/ _` | __/ _` |
    #  | | | | | | \__ \__ \ | | | | (_| |  | (_| | (_| | || (_| |
    #  |_| |_| |_|_|___/___/_|_| |_|\__, |   \__,_|\__,_|\__\__,_|
    #                                __/ |_____
    #                               |___/______|
    #
    #  missing_data
    # #############################################################
    tm_missing_data(
      label = "Missing data",
      decorators = list(
        summary_plot = plot_grob_decorator("A", "summary_plot"),
        combination_plot = plot_grob_decorator("B", "combination_plot"),
        summary_table = rlisting_decorator("table row", "table"),
        by_subject_plot = caption_decorator("by_subject_plot")
      )
    )
  )
) |> shiny::runApp()

github-actions · 2025-01-08T12:42:16Z

Unit Tests Summary

1 files 22 suites 13m 32s ⏱️
145 tests 108 ✅ 37 💤 0 ❌
477 runs 439 ✅ 38 💤 0 ❌

Results for commit 0b98cf4.

♻️ This comment has been updated with latest results.

github-actions · 2025-01-08T12:42:19Z

Unit Test Performance Difference

Test Suite	$Status$	Time on `main`	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
examples	💔	$0.57$	$+6.39$	$+1$	$0$	$0$	$0$
shinytest2-tm_a_pca	💔	$115.73$	$+5.90$	$0$	$0$	$0$	$0$
shinytest2-tm_a_regression	💔	$50.63$	$+3.21$	$0$	$0$	$0$	$0$
shinytest2-tm_data_table	💔	$18.17$	$+1.60$	$0$	$0$	$0$	$0$
shinytest2-tm_file_viewer	💔	$28.77$	$+1.30$	$0$	$0$	$0$	$0$
shinytest2-tm_front_page	💔	$20.34$	$+1.33$	$0$	$0$	$0$	$0$
shinytest2-tm_g_association	💔	$30.17$	$+1.63$	$0$	$0$	$0$	$0$
shinytest2-tm_g_bivariate	💔	$73.71$	$+2.08$	$0$	$0$	$0$	$0$
shinytest2-tm_g_response	💔	$28.74$	$+1.02$	$0$	$0$	$0$	$0$
shinytest2-tm_g_scatterplot	💔	$72.89$	$+2.43$	$0$	$0$	$0$	$0$
shinytest2-tm_g_scatterplotmatrix	💔	$27.29$	$+1.26$	$0$	$0$	$0$	$0$
shinytest2-tm_misssing_data	💔	$47.66$	$+1.77$	$0$	$0$	$0$	$0$
shinytest2-tm_outliers	💔	$108.93$	$+6.30$	$0$	$0$	$0$	$0$
shinytest2-tm_t_crosstable	💔	$31.18$	$+1.06$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on `main`	$±Time$	Test Case
examples	💔	$0.08$	$+1.69$	example_add_facet_labels.Rd
examples	💔	$0.01$	$+1.10$	example_tm_g_distribution.Rd
shinytest2-tm_g_scatterplot	💔	$42.31$	$+1.19$	e2e_tm_g_scatterplot_The_encoding_inputs_produce_output_without_validation_errors.

Results for commit 74972fd

♻️ This comment has been updated with latest results.

DESCRIPTION

R/roxygen2_templates.R

llrs-roche

tm_data_table: decorators removed

Sorry, I don't recall why we remove decorators only on this module. Could you remind me? Is it because it cannot be used with a reporter?

tm_missing_data: Decorators using rlisting instead of DataTable

When checking this module on ADRS tab "By Variable Levels" I get this error on the decorator (New row):

Error when executing the `data` module: is(tbl, "VTableTree") is not TRUE 
 when evaluating qenv code:
table <- rtables::insert_rrow(table, rtables::rrow("table row")) 
Check your inputs or contact app developer if error persists.

The decorator works for the tm_t_crosstable module so I guess the problem is on tm_missing_data.

tm_distribution: Was decorating data.frames in report, moved to rlisting

I don't see the decorator on the summary or test table but I do on the reporter (could be a problem on my machine):

tm_outliers: Code improvement

Looks good, minor suggestion: on line 892 there are multiple calls to commong_code_q() I would save one as qenv and reuse the qevn for extracting other dataset. Sorry it doesn't let me make the suggestion to code that wasn't modified.

R/utils.R

Co-authored-by: Lluís Revilla <185338939+llrs-roche@users.noreply.github.com> Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>

Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>

averissimo · 2025-01-09T11:07:41Z

tm_data_table: decorators removed

Sorry, I don't recall why we remove decorators only on this module. Could you remind me? Is it because it cannot be used with a reporter?

Exactly! Only objects that appear on the reporter are decorated. This also connects with the screenshot below

tm_missing_data: Decorators using rlisting instead of DataTable

When checking this module on ADRS tab "By Variable Levels" I get this error on the decorator (New row):
Error when executing the `data` module: is(tbl, "VTableTree") is not TRUE 
 when evaluating qenv code:
table <- rtables::insert_rrow(table, rtables::rrow("table row")) 
Check your inputs or contact app developer if error persists.

Thanks, there was this last leftover wrong decorator in the app it should use rlistings_decorator (corrected now)

The decorator works for the tm_t_crosstable module so I guess the problem is on tm_missing_data.

tm_distribution: Was decorating data.frames in report, moved to rlisting

I don't see the decorator on the summary or test table but I do on the reporter (could be a problem on my machine):

The decorator feature scope is limited to reporter for now. If we want to have a consistent TLGs we need to downgrade the DataTable visualizations and lose some of the the features inside the teal app (sort, search)

tm_outliers: Code improvement

Looks good, minor suggestion: on line 892 there are multiple calls to commong_code_q() I would save one as qenv and reuse the qevn for extracting other dataset. Sorry it doesn't let me make the suggestion to code that wasn't modified.

I suppose you mean this chunk?

llrs-roche · 2025-01-09T12:20:06Z

Exactly! Only objects that appear on the reporter are decorated. This also connects with the screenshot below
My memory is getting back after holidays :D . Ok with reverting decorators at tm_data_table👍

Yes! I meant that chunk highlighted on the image!
Just something I saw while checking the module's code, it is not a big deal but I thought it could be nice.

Feel free to ping me when the PR is ready for another pass (did you forget to push?).

llrs-roche

Looks good! Great work!

averissimo added 2 commits January 6, 2025 14:23

feat: initial copy of support functions

4420127

feat: source code standardization

b8c4674

averissimo added the core label Jan 6, 2025

averissimo added 9 commits January 6, 2025 14:53

docs: remove custom decorators parameter

e13dc89

docs: use generic section name

e5d4da1

del: remove decorating from data table

5c16b8c

feat: fixes missing data

5d570d6

feat: fix missing data decorators

fe3a48a

feat: convert tm_outliers

ebe7c1d

feat: convert tm_distribution

8ee1450

fix: ordering of columns and minor bug

e772983

fix: description

b0ccd51

averissimo marked this pull request as ready for review January 8, 2025 12:13

[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update

930e4a5

empty: trigger CI checks

9b3572a

averissimo commented Jan 8, 2025

View reviewed changes

DESCRIPTION Show resolved Hide resolved

averissimo commented Jan 8, 2025

View reviewed changes

R/roxygen2_templates.R Show resolved Hide resolved

llrs-roche self-assigned this Jan 8, 2025

llrs-roche reviewed Jan 8, 2025

View reviewed changes

R/utils.R Outdated Show resolved Hide resolved

R/utils.R Outdated Show resolved Hide resolved

averissimo and others added 3 commits January 8, 2025 17:13

Update R/utils.R

9bac933

Co-authored-by: Lluís Revilla <185338939+llrs-roche@users.noreply.github.com> Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>

Update R/utils.R

d34231e

Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>

[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update

3efb13a

chore: code improvement

0b98cf4

averissimo requested a review from llrs-roche January 9, 2025 13:43

llrs-roche approved these changes Jan 9, 2025

View reviewed changes

averissimo merged commit 21226d4 into main Jan 9, 2025
29 checks passed

averissimo deleted the 605-decorators@main branch January 9, 2025 14:44

github-actions bot locked and limited conversation to collaborators Jan 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvement on decorators #822

Improvement on decorators #822

averissimo commented Jan 6, 2025 •

edited

Loading

github-actions bot commented Jan 8, 2025 •

edited

Loading

github-actions bot commented Jan 8, 2025 •

edited

Loading

llrs-roche left a comment

averissimo commented Jan 9, 2025 •

edited

Loading

llrs-roche commented Jan 9, 2025

llrs-roche left a comment

Improvement on decorators #822

Improvement on decorators #822

Conversation

averissimo commented Jan 6, 2025 • edited Loading

Pull Request

Changes description

Modules that need recheck (for reviewer):

github-actions bot commented Jan 8, 2025 • edited Loading

Unit Tests Summary

github-actions bot commented Jan 8, 2025 • edited Loading

Unit Test Performance Difference

llrs-roche left a comment

Choose a reason for hiding this comment

averissimo commented Jan 9, 2025 • edited Loading

llrs-roche commented Jan 9, 2025

llrs-roche left a comment

Choose a reason for hiding this comment

averissimo commented Jan 6, 2025 •

edited

Loading

github-actions bot commented Jan 8, 2025 •

edited

Loading

github-actions bot commented Jan 8, 2025 •

edited

Loading

averissimo commented Jan 9, 2025 •

edited

Loading