Add documentation for the new Weekly InstructLab CLI Meeting #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
russellb
requested changes
May 16, 2024
Co-authored-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Nathan Weinberg <31703736+nathan-weinberg@users.noreply.github.com>
lhawthorn
approved these changes
May 16, 2024
There was a problem hiding this comment.
Noting @russellb's feedback on maximum line length linting for Markdown files - and this should be opened as a separate issue (if you would please do the honors, @nathan-weinberg) - this looks good to me.
Please rebase, @nathan-weinberg, so I can take one last look.
And noting to myself this should have been a review requesting changes and not a review with approval, which is my mistake. I am not certain how to fix that retroactively, but will investigate for future learnings.
|
@Mergifyio rebase |
✅ Nothing to do for rebase action |
Co-authored-by: Leslie Hawthorn <lhawthor@redhat.com> Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text is based off the existing text for the
Weekly All Community Meetingbut definitely open to suggestions!