This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
bpf-map-pinning: fixes a few issues #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryamtahhan
commented
Dec 2, 2023
|
I could also remove the bpf code from the CNI altogether by leveraging the DPSyncer and doing everything in the DP as part of this PR? |
maryamtahhan
force-pushed
the
hotfix_bpf_map_pinning
branch
from
0ded0d7 to
595d1b6
Compare
maryamtahhan
commented
Dec 4, 2023
maryamtahhan
commented
Dec 4, 2023
cmd/deviceplugin/main.go
Outdated
| @@ -144,6 +144,17 @@ func main() { | |||
| } | |||
| } | |||
|
|
|||
| if _, err := os.Stat(constants.Bpf.PinMapBaseDir); err == nil { | |||
There was a problem hiding this comment.
Might need to remove this...
maryamtahhan
commented
Dec 4, 2023
maryamtahhan
force-pushed
the
hotfix_bpf_map_pinning
branch
from
595d1b6 to
8a89a2f
Compare
* Update the documentation to reflect configuration changes needed. * Update the program to pin the xsk map to just use xdp-loader. The previous c implementation had issues and the version of libxdp in the container images is too old for libxdp pinning support. Reverting to bpf (for pinning support) would break the libxdp based program unloading. * Don't return an error from the bpf clean up function when there's no program on the interface. Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
maryamtahhan
force-pushed
the
hotfix_bpf_map_pinning
branch
from
8a89a2f to
6cc5d92
Compare
garyloug
approved these changes
Dec 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in a physical cluster with multiple pools and resource requests with both CNDP map pinning and soon to be map pinning patches submitted patches to DPDK