Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Add GRPC server options to meta options for plugins #89

Merged
merged 1 commit into from
Apr 28, 2018

Conversation

zcarlson-signifai
Copy link

Implements intelsdi-x/snap-plugin-lib-go issue #43 (Allow grpc Server options to be passed by plugin author).

I took the approach that GRPC server options shouldn't be restricted because restriction can be accomplished later by enforcing (applying) desired restricted options after the user-defined options have been applied.

@PatrykMatyjasek
Copy link
Contributor

Thanks for your contribution.
We are thinking about include your enhancement into examples. It can be done in another PR, but feel free if you want to update this one

@zcarlson-signifai
Copy link
Author

I don't think I'm understanding properly -- are you requesting I include my enhancement usage in one of the plugins already present in the examples as well, as a requirement for merge?

@PatrykMatyjasek
Copy link
Contributor

@zcarlson-signifai it will be great if you could update one of existing plugins with your enhancement, but it is not required for merge.

@aasssddd
Copy link

I have the same issue as intelsdi-x/snap-plugin-lib-go issue #43
may i ask how to fix this without @zcarlson-signifai's PR?

@tnachen
Copy link

tnachen commented Nov 16, 2017

Anyone here to merge this patch? Is this library still being maintained?

@zcarlson-signifai
Copy link
Author

Is there anything blocking this PR from being merged that I can help with?

@Yajuan-Shi
Copy link
Contributor

GRPC server option can work with this change. Will add option setting in example plugin.

@Yajuan-Shi Yajuan-Shi merged commit 754a880 into intelsdi-x:master Apr 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants