This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
GetValueByNamespace extended to support retrieving values from maps a… #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return GetStructValueByNamespace(object, ns) | ||
| case reflect.Struct: | ||
| return GetStructValueByNamespace(object, ns) | ||
| } |
There was a problem hiding this comment.
I suggest adding default case to this switch with some log
|
I think this code cannot manage with cases when:
Even if that gonna stay unimplemented at least you should leave |
…nd arrays //TODO added to GetValueByNamespace
|
@lmroz Thanks for your review. This change is needed for intelsdi-x/snap-plugin-collector-facter#15 so for now I add //TODO notes as you've suggested. Would you mind creating an issue with exact description of cases that should be handled by GetValueByNamespace()? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd arrays
Changes made in this PR: