Add scroll to top button to web page #92
Conversation
|
@AdrianBZG @Nikhil-Vats Kindly review Pull Request for issue #90 |
|
Nice work @Emuohwo. Everything works as expected. 💯 👍 🎉 I think this class is not used anywhere and can be removed. I tried removing it and everything works just fine. @AdrianBZG what do you think? One more thing, for smaller screens the button overlaps footer content - I think we can increase bottom to 40px and it will be better that way, see -
|
|
Hi @Emuohwo , Nice work, if you could address the issue pointed by @Nikhil-Vats (increase bottom to 40px), we'd happy to accept this PR 😄 |
|
@Nikhil-Vats and @AdrianBZG consider it done. |
|
@Nikhil-Vats and @AdrianBZG the scroll button still covered part of the footer content even after I have increase bottom to
|
|
@Emuohwo Nice work on the media query! 🎉 💯 |
|
@Nikhil-Vats I have increased the width to 785px for the media query. |
|
@Emuohwo Good work! 💯 |
#92) This commit addresses these two issues: 1) Some mine/class combinatins may return partial data or no results at all. This is handled by displaying informational cards so the user is made aware of this. 2) Some mine/class combinations may not have one or more of the default constraints. For now the unavailable constraints are just removed from the view. Closes: #91 Squashed commits: * Disable constraints for unavailable constraints in mine/class * Handle errors when constraint path is unavailable * Inform the user when there are no gene lengths for the mine/class combo * Inform the user when there is no table data for the mine/class combo * Inform the user when there is no organism summary for the mine/class combo
Description
Describe the changes made and why they were made.
Added a container in footer.pug for the scroll to top button: this is the container where the scroll button is located.
Added js code for the button to common.js: I want to button to trigger when a user scroll to a certain level downward
I did the styling of the button in _global.scss: This is to give the button a good look
Related issues and discussion
#90
Screenshots, if any
This is the look on small screen
On a bigger screen
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!