Merge pull request #11 from invenia/rf/long-msgs

Warn vs error on messages that are too long

REQUIRE

@@ -1,6 +1,6 @@
 julia 0.7
 AWSCore 0.3
 MbedTLS
-Memento 0.9
+Memento 0.12.1
 Mocking 0.5.3
 TimeZones 0.5

src/event.jl

@@ -35,9 +35,11 @@ struct LogEvent
         end
 
         if sizeof(message) > MAX_EVENT_SIZE - 26
-            throw(ArgumentError(
-                "Log Event message cannot be more than than $MAX_EVENT_SIZE bytes"
-            ))
+            # Truncate message and throw a warning
+            idx = MAX_EVENT_SIZE - 29
+            # Truncated messages include a "..."
+            message = string(message[1:idx], "...")
+            warn(LOGGER, "CloudWatch Log Event message cannot be more than $MAX_EVENT_SIZE bytes")
         end
 
         if timestamp < 0

test/event.jl

@@ -26,7 +26,9 @@ end
 @testset "Bad construction" begin
     @test_throws ArgumentError LogEvent("")
     @test_throws ArgumentError LogEvent("Foo", -45)
-    @test_throws ArgumentError LogEvent("A" ^ (CloudWatchLogs.MAX_EVENT_SIZE - 25))
+    @test_warn getlogger("CloudWatchLogs") "Log Event message cannot be more than" begin
+        LogEvent("A" ^ (MAX_EVENT_SIZE - 25))
+    end
 end
 
 end

test/runtests.jl

@@ -2,6 +2,7 @@ using Mocking
 Mocking.enable(; force=true)
 
 using CloudWatchLogs
+using CloudWatchLogs: MAX_EVENT_SIZE
 
 import AWSCore
 import AWSCore.Services: logs, sts