Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Memento>=1.3 #47

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Support Memento>=1.3 #47

merged 3 commits into from
Jan 10, 2023

Conversation

timmylev
Copy link
Member

No description provided.

iamed2
iamed2 reviewed Jan 10, 2023
View reviewed changes
src/handler.jl Outdated Show resolved Hide resolved
@iamed2
Copy link
Member

iamed2 commented Jan 10, 2023

I believe the tests are failing due to #45

You can comment out the Invalid sequence token testset and reference that issue, or address the issue if you feel like it (but it's not worth spending much time on).

timmylev and others added 2 commits January 10, 2023 18:07
@timmylev @iamed2
Update src/handler.jl
1ab8885 
Co-authored-by: Eric Davies <iamed2@gmail.com>
@timmylev
comment out invalid sequence token testset because InvalidSequenceTok…
aa4d7e2 
…en errors are no longer a thins
@timmylev timmylev merged commit a6dbce2 into master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamed2 iamed2 iamed2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timmylev @iamed2