fix: Handle undefined record attributes in templates to avoid rendering errors #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samk13
force-pushed
the
fix-template-description-check
branch
from
3c86a5d to
b723bc6
Compare
Samk13
changed the title
tmorrell
approved these changes
Dec 5, 2024
invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/macros/detail.html
Outdated
Show resolved
Hide resolved
invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/macros/detail.html
Outdated
Show resolved
Hide resolved
Samk13
force-pushed
the
fix-template-description-check
branch
2 times, most recently
from
4cc21a0 to
95c5d20
Compare
Samk13
commented
Dec 6, 2024
* Handle missing 'type' in description rendering * Add the missing description type when the type is not specified. * closes inveniosoftware#2931
* fix show_dates * fix _identifiers_for_group * fix show_related_identifiers by filtering with selectattr: https://jinja.palletsprojects.com/en/stable/templates/#jinja-filters.selectattr
Samk13
force-pushed
the
fix-template-description-check
branch
from
7a953f3 to
4fa5c3e
Compare
Samk13
commented
Jan 17, 2025
| @@ -39,7 +39,7 @@ | |||
|
|
|||
|
|
|||
| {% macro show_creatibutors(creatibutors, show_affiliations=False, type="creators", show_role=False) %} | |||
| {% for creatibutor in creatibutors %} | |||
| {% for creatibutor in creatibutors if creatibutor.person_or_org and creatibutor.person_or_org.name %} | |||
There was a problem hiding this comment.
While in community review, you can edit a contributor by removing their name but keeping the required role. Upon saving, the reviewer will encounter an error.
Samk13
force-pushed
the
fix-template-description-check
branch
from
4fa5c3e to
8f053c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: