Merge pull request #32 from andreasrueedlinger/master

Fixes #391
inversify · Oct 14, 2016 · f7f3fd7 · f7f3fd7
2 parents a878641 + 63877da
commit f7f3fd7
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 1 deletion.
diff --git a/src/serializers/text/binding_serializer.ts b/src/serializers/text/binding_serializer.ts
@@ -30,7 +30,7 @@ function serializeBinding(
                     val = scopeFormatter(_b[prop]);
                     break;
                 case "implementationType":
-                    val = _b[prop].name;
+                    val = _b[prop] && _b[prop].name;
                     break;
                 case "serviceIdentifier":
                     val = serviceIdentifierFormatter(_b[prop]);

diff --git a/test/index.test.ts b/test/index.test.ts
@@ -512,4 +512,45 @@ describe("makeLoggerMiddleware", () => {
 
     });
 
+    it("Should be able to serialize constant values like strings", () => {
+
+        const TYPES = {
+            MyStringValue: Symbol("MyStringValue")
+        };
+
+        const kernel = new Kernel();
+        kernel.bind<string>(TYPES.MyStringValue).toConstantValue("foo");
+
+        let out = "";
+        let logger = makeLoggerMiddleware(null, (entry) => { out = textSerializer(entry); });
+        kernel.applyMiddleware(logger);
+        kernel.get<string>(TYPES.MyStringValue);
+
+        let expectedOut = "SUCCESS: 0.75 ms.\n" +
+        "    └── Request : 0\n" +
+        "        └── serviceIdentifier : Symbol(MyStringValue)\n" +
+        "        └── bindings\n" +
+        "            └── Binding<Symbol(MyStringValue)> : 0\n" +
+        "                └── type : ConstantValue\n" +
+        "                └── implementationType : null\n" +
+        "                └── scope : Transient\n";
+
+        let lines = out.split("└── ")
+                        .map((line) => {
+                            return line.split("\u001b[33m").join("")
+                                        .split("\u001b[39m").join("");
+                        });
+
+        let expectedLines = expectedOut.split("└── ");
+
+        lines.forEach((line: string, index: number) => {
+            if (index > 0) {
+                expect(line.trim()).eql(expectedLines[index].trim());
+            } else {
+                expect(line.indexOf("SUCCESS")).not.to.eql(-1);
+            }
+        });
+
+    });
+
 });