Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk, android): adopt firebase-android-sdk 32.7.0 #7506

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

mikehardy
Copy link
Collaborator

Description

Nearly trivial change for the SDK, definitely trivial for us, but best practice to have current SDKs available

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

I ran e2e tests on android and ios locally, all green


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 5:12am
react-native-firebase-next ❌ Failed (Inspect) Dec 13, 2023 5:12am

macos-13 / xcode15 is too slow for successful testing
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #7506 (63b0b8f) into main (41c9c20) will increase coverage by 0.37%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7506      +/-   ##
============================================
+ Coverage     52.93%   53.29%   +0.37%     
+ Complexity      739      738       -1     
============================================
  Files           251      251              
  Lines         12391    12391              
  Branches       1936     1936              
============================================
+ Hits           6558     6603      +45     
+ Misses         5481     5440      -41     
+ Partials        352      348       -4     

@mikehardy mikehardy merged commit 29a42c3 into main Dec 13, 2023
16 checks passed
@mikehardy mikehardy deleted the @mikehardy/android-32.7.0 branch December 13, 2023 06:03
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant