-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc,TensorVis,VectorVis: core logging changes #248
Conversation
Cpp-Linter Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cpp-linter Review
Used clang-tidy v17.0.6
Click here for the full clang-tidy patch
diff --git a/tensorvis/tensorvisbase/src/processors/invariantspacefilter.cpp b/tensorvis/tensorvisbase/src/processors/invariantspacefilter.cpp
index cf66a59..17c935e 100644
--- a/tensorvis/tensorvisbase/src/processors/invariantspacefilter.cpp
+++ b/tensorvis/tensorvisbase/src/processors/invariantspacefilter.cpp
@@ -90 +90,2 @@ void InvariantSpaceFilter::process() {
- (float(numberOfFilteredTensors) / float(numberOfElements)) * 100.f,
+ (static_cast<float>(numberOfFilteredTensors) / static_cast<float>(numberOfElements)) *
+ 100.f,
Have any feedback or feature suggestions? Share it here.
<< "% filtered (" << std::to_string(numberOfFilteredTensors) << " out of " | ||
<< std::to_string(numberOfElements) << ")."); | ||
log::info("{}% filtered ({} out of {})", | ||
(float(numberOfFilteredTensors) / float(numberOfElements)) * 100.f, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy diagnostics
- C-style casts are discouraged; use static_cast [google-readability-casting]
- C-style casts are discouraged; use static_cast [google-readability-casting]
(float(numberOfFilteredTensors) / float(numberOfElements)) * 100.f, | |
(static_cast<float>(numberOfFilteredTensors) / static_cast<float>(numberOfElements)) * | |
100.f, |
reflects latest core changes related to logging