feat(tab-bar): make box shadow independent of expand mode #30117
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OS-pedrolourenco
changed the title
OS-pedrolourenco
requested review from
brandyscarney
and removed request for
thetaPC
|
@OS-pedrolourenco please make sure the PR checks are passing before marking it ready for review. It speeds up the process for the reviewer. |
There was a problem hiding this comment.
One small nitpick, the PR title. This is not a feat, a feat is when we're adding something new. In this case, we're making a change to an existing style, so it's a refactor. Also we try to start the sentence with a verb.
refactor(tab-bar): make box shadow independent of expand for ionic
|
@thetaPC I have changed the behaviour of the tab-bar so that it now has a shadow when its expand mode is 'full' and not just 'compact', as requested by UX. Wouldn't you say that that is feature and not a refactor? |
OS-pedrolourenco
changed the title
As you mentioned, you did a code change so that's a refactor. Here's the definitions for:
Edit: |
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> This PR is a follow-up of this one: #30117 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - This PR adds a snapshot test and modifies the existing one in order to test the change done in the previous PR. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: Maria Hutt <maria@ionic.io>
Issue number: internal
What is the current behavior?
When the tab bar's expand mode is 'full' on the ionic theme, it does not have a box shadow to separate it from the rest of the page.
What is the new behavior?
Does this introduce a breaking change?
Other information