Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ipns cleanup #59

Merged
merged 1 commit into from
Sep 10, 2019
Merged

chore: ipns cleanup #59

merged 1 commit into from
Sep 10, 2019

Conversation

lidel
Copy link
Member

@lidel lidel commented Sep 9, 2019 •
edited
Loading

Some mirrors were IPNS-only, and old IPNS keys seem to be lost. Broken links should not be kept around.
We can introduce IPNS again after #58 is in place, for now /ipfs/ and DNSLink (ipfs/infra#491) should be enough.

Closes #52

@lidel lidel requested a review from momack2 September 9, 2019 13:38
momack2
momack2 approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@momack2 momack2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the fact we can revive old IPFS links by reviving old content generally makes me want to hold on to old links just in case - I don't feel the same about old IPNS links. LGTM

@lidel lidel merged commit 3ab3e07 into master Sep 10, 2019
@lidel lidel deleted the chore/ipns-cleanup branch September 10, 2019 11:20
@lidel lidel mentioned this pull request Oct 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momack2 momack2 momack2 approved these changes

@mburns mburns mburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipns link broken
3 participants
@lidel @mburns @momack2