Rework the handling of FMTID0 in OlePropertiesContainer #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpsy
commented
Nov 17, 2024
| @@ -36,6 +48,7 @@ public OlePropertiesContainer(int codePage, ContainerType containerType) | |||
| }; | |||
|
|
|||
| ContainerType = containerType; | |||
| FMTID0 = FmtIdFromContainerType(containerType); | |||
There was a problem hiding this comment.
There was a previous suggestion to add a constructor that allows users to specify the fmtid to use rather than inferring it such that values the library doesn't know about can be used, but I don't need tht ability myself so I never spent any time on it.
Could be done later if useful though
Numpsy
commented
Nov 17, 2024
| /// <summary> | ||
| /// Gets the FMTID of the properties container. | ||
| /// </summary> | ||
| public Guid FMTID0 { get; } | ||
|
|
||
| public PropertyContext Context { get; } | ||
|
|
||
| private readonly List<OleProperty> properties = new(); | ||
| internal Stream? cfStream; |
There was a problem hiding this comment.
A thought when looking at this - is there actually a need to keep the stream as a member?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #142 but against v3.0 and with an extension to one of the unit tests to test that it retains the fmtid for a file with an 'app specific' (i.e not a known value) value,