-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content: enhance README #1132
content: enhance README #1132
Conversation
⚡ Lighthouse report for the home page 🏠
Other pages
|
Uhm, we should IMO refactor the That way the WDYT about: "scripts": {
"copy-assets": "cp -r node_modules/bootstrap-italia/dist/svg/ static/ && cp -r node_modules/bootstrap-italia/dist/fonts static/",
"...": "...",
"prestart": "npm run copy-assets"
"start": "gatsby develop",
"...": "...",
"prebuild": "npm run copy-assets"
"build": "gatsby build --prefix-paths" Also, I'd rename Something like Bonus: it would make sense to run it from here automatically: https://github.com/italia/designers.italia.it/blob/main/.github/workflows/bsi-update.yml |
All cool to me. If these things are feasible in a short period of time let's proceed directly on this branch. If not, I would prefer to take an intermediate step by first updating the README to the state of the art, then later opening a PR dedicated to evolutions. WDYT?
Not really. It is one thing to update BSI of the site. That can happen automatically, although at the moment PR for some reason actually still doesn't go through and will have to be fixed. |
Sounds good, the renaming part is really simple and can be done quickly in this PR.
Uhm, so there is no link between the locally installed Bootstrap Italia and the examples generation. This threw me off: https://github.com/italia/designers.italia.it/blob/main/scripts/generate-examples.js#L6 and I think it's wrong, IIUC. |
fix: #1072