Node 20 #279
Open
Node 20 #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speed up container creation and prevents packages cross compiled from a different node version to "bleed into" the container image when building locally
made `docker build` work for node 20 removed unnecessary, broken or deprecated dependencies that could not run in node 20; modified `spid-validator/server/api/metadata-sp.js`: removed deprecated 'unzip' dep -> replacd with [yauzl](https://www.npmjs.com/package/yauzl) modified `spid-validator/server/lib/utils.js`: removed deprecated 'uuidjs' dep -> replaced with standard crypto.randomUUID();
|
Also, i have the concern that this repository is no longer mantained as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to update to Node.js 20 LTS for
server.Managed to get
docker buildto work with node:20 base image.Removed or found alternatives for dependencies that broke in node 20, also tried to remove dependencies that had security vulnerabilities for
server.There is still work to do though:
cd spid-validator/client && npm audit> client.audit.txtcd spid-validator/server && npm audit> server.audit.txtremoved unnecessary, broken or deprecated dependencies that could not run
in node 20;
modified
spid-validator/server/api/metadata-sp.js:removed deprecated 'unzip' dep -> replaced with yauzl
modified
spid-validator/server/lib/utils.js:removed deprecated 'uuidjs' dep -> replaced with standard crypto.randomUUID();