catch HfHubHTTPError in hf-dataset-llm-eval example #848
+15
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
db7e73f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://abdeaa78.datachain-documentation.pages.dev |
| Branch Preview URL: | https://improve-hf-example.datachain-documentation.pages.dev |
mattseddon
force-pushed
the
improve-hf-example
branch
2 times, most recently
from
a20da5b to
7aba619
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
=======================================
Coverage 87.59% 87.59%
=======================================
Files 128 128
Lines 11382 11382
Branches 1540 1540
=======================================
Hits 9970 9970
Misses 1025 1025
Partials 387 387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mattseddon
force-pushed
the
improve-hf-example
branch
2 times, most recently
from
ea88557 to
2463dc6
Compare
dreadatour
approved these changes
Jan 27, 2025
| response_format={"type": "json", "value": DialogEval.model_json_schema()}, | ||
| ) | ||
| except HTTPError: | ||
| return DialogEval(result="Error", reason="Huggingface API returned an error.") |
There was a problem hiding this comment.
Strictly saying it can also be not only an error from Huggingface API, but also general HTTP error (404 Not Found, for example), we may want to raise something like "Error while interacting with the Hugging Face API".
mattseddon
force-pushed
the
improve-hf-example
branch
from
2463dc6 to
db7e73f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patching the error shown here: https://github.com/iterative/datachain/actions/runs/12888313233/job/35932939032
Failed here too: https://github.com/iterative/datachain/actions/runs/12899335202/job/35967939172?pr=850