Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Fabric 1.21 #12

Open
wants to merge 9 commits into
base: 1.20.4
Choose a base branch
from

Conversation

handsome-steve
Copy link

Request to update mod to 1.21 for Fabric.

Signed-off-by: handsome-steve <51927714+handsome-steve@users.noreply.github.com>
…ocks with 'AbstractBlock.Settings'

Signed-off-by: handsome-steve <51927714+handsome-steve@users.noreply.github.com>
…d accessible method 'getBaseDimensions'.

Signed-off-by: handsome-steve <51927714+handsome-steve@users.noreply.github.com>
…e modifying player hunger.

Signed-off-by: handsome-steve <51927714+handsome-steve@users.noreply.github.com>
Modified Loot Tables for "leaf type" blocks to ensure proper loot tables drop for 1.21
Added "sn0wfrogs_capybaras:flowering_mandarin_leaves" to both 'leaves'.json in for block and item tags.

Signed-off-by: handsome-steve <51927714+handsome-steve@users.noreply.github.com>
Signed-off-by: handsome-steve <51927714+handsome-steve@users.noreply.github.com>
…a Version 21.

Signed-off-by: handsome-steve <51927714+handsome-steve@users.noreply.github.com>
Reverted 'ModStatusEffects' class changes and used 'Registries.STATUS_EFFECT.getEntry(ModStatusEffects.{STATUS_EFFECT})' when returning 'RegistryEntry<StatusEffect>' across the mod.

Reorganized the order which things are initialized in 'Sn0wfrogsCapybaras.onInitialize()' to prevent accessibility errors from being thrown and crashing the game (was not an issue before, but can be an issue moving forward).

Updated Mod version and naming scheme to '1.2.1+mc1.21'
@handsome-steve
Copy link
Author

Hey, just saw that you tried to run a check, it might be a good idea to push these changes to a new branch.
I can't select a 1.21 branch until you make one. :)

@iuriineves iuriineves self-requested a review September 20, 2024 15:54
@handsome-steve
Copy link
Author

1.21 Does not use Java 17 (17, ubuntu-22.04) anymore, so it will always fail there, hence why it runs on Java 21 (21, ubuntu-22.04).
Like I suggested before, if you make a branch for 1.21, it would be better to push the merge there, instead of affecting the 1.20.4 code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant