Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Computing Method of PTerm #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change the Computing Method of PTerm #4

wants to merge 2 commits into from

Conversation

lzbsuzhou
Copy link

My Problems

I have used the codes to do temperature control, it is useful. But sometimes, it could not work.

PTerm may be a instant value

alt pid
From the photo, I think the PTerm is a instant value. So I changed the method and do some new tests. I did some change in the test file, changed the sample time to 0.1s and loop time to 0.01s , the result was better than the original codes.

@Ghostbird
Copy link
Contributor

As far as I can see, the only thing you did is break the sample functionality.

The sample functionality allows you to let the PID controller run at a lower frequency than the calls to update(). You changed it so that if you try to run it at a lower frequency than the update() calls, it starts to act as a P controller in between, thus destabilising the controller.

However, I'm an information engineer, and not all that familiar with PID control so maybe I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants