Fix few things and python3 compatibility #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently I wasn't watching this repos. Thanks @BLaurent. The internal github repository is unfortunately disconnected from the public one so not everything is published here yet. I had done some verification on Python 3.6 but I'll take a closer look at what you have here to see if you caught anything else since the integration tests are still pretty limited. Thanks! |
j12y
approved these changes
Feb 2, 2018
predix/admin/timeseries.py
Outdated
| @@ -1,6 +1,7 @@ | |||
|
|
|||
| import os | |||
| import urlparse | |||
|
|
|||
| from future.moves.urllib.parse import urlparse | |||
There was a problem hiding this comment.
Yep, using this one now. I considered whether to use six but seemed to make no difference.
| @@ -83,7 +84,7 @@ def get_query_zone_id(self): | |||
|
|
|||
| def get_ingest_uri(self): | |||
| """ | |||
| Return the uri used for ingesting data into time series | |||
| Return the uri used for ingesting data into time series | |||
There was a problem hiding this comment.
I guess I haven't run the linter in awhile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found some issues, Please feel free to comment.
Best regards
B