joda-convert and joda-time #24
Conversation
advayDev1
force-pushed
the
lib-joda-time
branch
4 times, most recently
from
a0bce98 to
0ab892e
Compare
|
@brunobowden : ready to review, but you need to do all the other PRs #23 #22 #21 first. This is what it looks like when we know some of our libraries don't translate: I think it is good to have them anyway, as it documents in the logs exactly what needs to be fixed to get a working system. |
|
The output for mixed failures and successes on builds is great. I agree that they should be separate builds to make tracking and fixes easier. |
advayDev1
force-pushed
the
lib-joda-time
branch
2 times, most recently
from
8835129 to
5ea60b2
Compare
|
Well that's kind of annoying of github... Once I updated this PR I don't see any of your comments on the individual commit - I'd seen them before. I see you've already LGTM-ed the next PR #26 , but please do PTAL this one. I've basically updated this PR with respect to the comments from the last one #23 . @brunobowden |
| @@ -7,6 +7,15 @@ os: osx | |||
| # on Traivs. | |||
| env: | |||
| - TEST_DIR=com.google.code.gson-gson | |||
| - TEST_DIR=org.joda-joda-convert | |||
| - TEST_DIR=joda-time-joda-time | |||
There was a problem hiding this comment.
yes that is indeed the ugly fully qualified name for this.
like apache, joda is not consistent with its group id
There was a problem hiding this comment.
I asked britter about this in the other thread. Let's see if he responds with some insights.
There was a problem hiding this comment.
I mean it is definitely correct:
https://github.com/JodaOrg/joda-time/blob/master/pom.xml#L8
just odd
They have known issues, but we add them anyway to track when they get fixed. Adds a proper design for multi-library projects and for libraries that depend on other libraries we also test. Fixes j2objc-contrib#14 Fixes j2objc-contrib#25
advayDev1
force-pushed
the
lib-joda-time
branch
from
5ea60b2 to
91b6093
Compare
|
|
||
| matrix: | ||
| allow_failures: | ||
| # Blocked on https://github.com/JodaOrg/joda-convert/issues/7 |
There was a problem hiding this comment.
Further expand comment:
# Should be fixed in next release: version 1.8
There was a problem hiding this comment.
We don't know that. The next version number is something they'll come up with (maybe 1.7.1, maybe 2.0, etc.), and even that we have no guarantee they will actually release. The link is sufficient - no reason to add possibly wrong info.
There was a problem hiding this comment.
Namely, this is a snapshot only:
https://github.com/JodaOrg/joda-convert/blob/master/pom.xml#L12
When release time comes, depending on the API changes the maintainer might need to call it 2.0, 1.7.1, etc.
|
No problem, happy to go through it again. I tried doing the reviews on the individual commit... so that I could isolate review to only the part that changed. It may have been that if I did the comment on the PR, then it would've preserved the comments. LGTM after addressing prior comments. |
|
thanks btw: yes comments on PRs are preserved on the page (as 'outdated') even when the old commit is obliterated by |
They have known issues, but we add them anyway to track when they get fixed.
Adds a proper design for multi-library projects and for libraries that
depend on other libraries we also test.