Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the pluginHead branch auto sync to plugin head. #38

Closed
wants to merge 2 commits into from

Conversation

advayDev1
Copy link
Contributor

And document it.

Fixes #33

NOTE: This is a merge of a branch in the main repo to master. I could not figure out a way to propose a merge request from my fork to a not-yet-existent branch in the upstream. After this PR goes through we would keep pluginHead, and then merge master into pluginHead whenever new libraries are added.

@advayDev1
Copy link
Contributor Author

I'm not a fan of having to constantly remerge master into pluginHead. If you've got a better idea, let's do that and delete this branch (it has no effect on master yet).

# master branch's j2objc-gradle submodule should track
# only the latest production release of j2objc-gradle.
# For now it tracks a particular unreleased commit because v0.5.0-alpha
# must be released for depedency features to work.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/depedency/dependency/

Also, I didn't understand what you meant by this?

@brunobowden
Copy link
Contributor

We can get it to build to the latest version by querying the repo tags - see comments about this.

My big question is how is this build triggered? On a time basis, e.g. every 24 hours? It looks like Travis-CI isn't interested in kicking off a build based on a dependant repo: travis-ci/travis-ci#631

@advayDev1
Copy link
Contributor Author

Per #38 (comment) I'm just closing this PR for now.

We don't need this complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants