Fixed Auto Scroll Issue #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR @sgadman ! I'll review your changes when I have some time. |
|
@jacobworrel Have you had a chance to look at this PR? |
|
Bump. Would love to have these changes merged |
|
I have been swamped with work and havent been able to review these changes but am hoping to get around to it sometime. 😔 |
vikkrantxx7
reviewed
Sep 26, 2022
| } | ||
| }, | ||
| [currentIndex, children, list] | ||
| [currentIndex, children, list, ref] |
There was a problem hiding this comment.
ref is unnecessary in the dependency.
vikkrantxx7
reviewed
Sep 26, 2022
| const menuRect = refCurrent.getBoundingClientRect(); | ||
|
|
||
| if (Math.abs(currentItemRect.top - menuRect.bottom) <= Math.abs(currentItemRect.top - menuRect.top)) { | ||
| if (currentItemRect.top + 5 >= menuRect.bottom) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution to fix the auto scroll issue described in Issue #59