Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[deps]: Upgrade redux and react-redux to latest version (#2623)
## Which problem is this PR solving? - resolves #2530 ## Description of the changes - With redux 5, type of an action is now a `string`. According to them, this change is to make the action obj serializable. Change log: https://redux.js.org/usage/migrations/migrating-rtk-2#action-types-must-be-strings - In the test, due to some import error, redux no longer has configurable properties, and jest requires them to be configurable for spying and changing their behavior. [More context](https://stackoverflow.com/a/72885576/17456074) on this. - Since we are using `requireActual` in `jest.mock`, it would anyway be the actual implementation of functions for other test cases. ## How was this change tested? - `npm run start` is working fine ## How was this upgrade carried out? 1. `npm uninstall react-redux -w packages/jaeger-ui` to remove `react-redux` 2. `npm uninstall redux -w packages/jaeger-ui` to remove `redux` 3. `npm install react-redux -w packages/jaeger-ui` to install react-redux latest version. This installed the latest version but the package was nested in jaeger-ui node modules so had to do step 4. 4. Even with 2nd step, there was an entry of redux v4.2.1 in lockfile and package was installed in root node_modules. 5. I manually removed that entry from lockfile, and again ran `npm install redux -w packages/jaeger-ui`. This worked. 6. Again ran `npm uninstall react-redux -w packages/jaeger-ui` to remove `react-redux` nested entry in lockfile 7. `npm install react-redux -w packages/jaeger-ui` to install react-redux latest version. This finally created an entry in root node_modules in lockfile. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
- Loading branch information