code fixes to use new grpc api #5335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.62.1 to 1.63.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.62.1...v1.63.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: danish siddiqui <danishsiddiqui040@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5335 +/- ##
===========================================
- Coverage 95.24% 45.26% -49.99%
===========================================
Files 340 212 -128
Lines 16672 10989 -5683
===========================================
- Hits 15879 4974 -10905
- Misses 603 5563 +4960
- Partials 190 452 +262
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Apr 6, 2024
| @@ -81,7 +81,8 @@ func createProcessor(t *testing.T, mFactory metrics.Factory, tFactory thrift.TPr | |||
|
|
|||
| func initCollectorAndReporter(t *testing.T) (*metricstest.Factory, *testutils.GrpcCollector, reporter.Reporter, *grpc.ClientConn) { | |||
| grpcCollector := testutils.StartGRPCCollector(t) | |||
| conn, err := grpc.Dial(grpcCollector.Listener().Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) | |||
| conn, err := grpc.NewClient(grpcCollector.Listener().Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) | |||
| grpc.NewClient(grpcCollector.Listener().Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) | |||
proto-gen/api_v2/sampling.pb.go
Outdated
| @@ -507,7 +507,7 @@ func (c *samplingManagerClient) GetSamplingStrategy(ctx context.Context, in *Sam | |||
| out := new(SamplingStrategyResponse) | |||
| err := c.cc.Invoke(ctx, "/jaeger.api_v2.SamplingManager/GetSamplingStrategy", in, out, opts...) | |||
| if err != nil { | |||
| return nil, err | |||
| return nil, fmt.Errorf("Error while dialing: %w",err) | |||
There was a problem hiding this comment.
This is autogenerated file, please revert
yurishkuro
requested changes
Apr 6, 2024
| @@ -149,8 +149,8 @@ func TestGRPCStorageFactory(t *testing.T) { | |||
|
|
|||
| func TestGRPCStorageFactoryWithConfig(t *testing.T) { | |||
| cfg := grpcConfig.Configuration{} | |||
| _, err := NewFactoryWithConfig(cfg, metrics.NullFactory, zap.NewNop()) | |||
| require.ErrorContains(t, err, "grpc-plugin builder failed to create a store: error connecting to remote storage") | |||
Pushkarm029
reviewed
Apr 21, 2024
| return s.client.GetSamplingStrategy(ctx, &api_v2.SamplingStrategyParameters{ServiceName: serviceName}) | ||
| resp, err := s.client.GetSamplingStrategy(ctx, &api_v2.SamplingStrategyParameters{ServiceName: serviceName}) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("our internal message/explanation: %w", err) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("our internal message/explanation: %w", err) | |
| return nil, fmt.Errorf("failed to get sampling strategies: %w", err) |
this can be improved
|
fixed in #5336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test