Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Move cmd/collector/app/sampling/model types to storage #6531

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

ary82
Copy link
Contributor

@ary82 ary82 commented Jan 12, 2025

Which problem is this PR solving?

Description of the changes

  • Involves refactoring the model package in cmd/collector/app/sampling
  • Move specific plugin/storage/cassandra/samplingstore types to that package as internal types
  • Move the other types to storage/samplingstore/model

How was this change tested?

  • Covered by existing

Checklist

Signed-off-by: Aryan Goyal <137564277+ary82@users.noreply.github.com>
@yurishkuro yurishkuro changed the title refactor: move cmd/collector/app/sampling/model types to storage [refactor] Move cmd/collector/app/sampling/model types to storage Jan 12, 2025
@yurishkuro yurishkuro enabled auto-merge (squash) January 12, 2025 21:42
@yurishkuro
Copy link
Member

lgtm

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (77c5f2a) to head (74c096b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6531   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files         372      372           
  Lines       21360    21360           
=======================================
  Hits        20551    20551           
  Misses        616      616           
  Partials      193      193           
Flag Coverage Δ
badger_v1 10.65% <0.00%> (ø)
badger_v2 2.78% <0.00%> (ø)
cassandra-4.x-v1-manual 16.55% <0.00%> (ø)
cassandra-4.x-v2-auto 2.71% <0.00%> (ø)
cassandra-4.x-v2-manual 2.71% <0.00%> (ø)
cassandra-5.x-v1-manual 16.55% <0.00%> (ø)
cassandra-5.x-v2-auto 2.71% <0.00%> (ø)
cassandra-5.x-v2-manual 2.71% <0.00%> (ø)
elasticsearch-6.x-v1 20.23% <0.00%> (ø)
elasticsearch-7.x-v1 20.30% <0.00%> (ø)
elasticsearch-8.x-v1 20.45% <0.00%> (-0.01%) ⬇️
elasticsearch-8.x-v2 2.78% <0.00%> (+<0.01%) ⬆️
grpc_v1 12.17% <0.00%> (-0.01%) ⬇️
grpc_v2 9.04% <0.00%> (ø)
kafka-3.x-v1 10.34% <0.00%> (ø)
kafka-3.x-v2 2.78% <0.00%> (ø)
memory_v2 2.77% <0.00%> (-0.01%) ⬇️
opensearch-1.x-v1 20.34% <0.00%> (-0.01%) ⬇️
opensearch-2.x-v1 20.35% <0.00%> (ø)
opensearch-2.x-v2 2.77% <0.00%> (-0.11%) ⬇️
tailsampling-processor 0.51% <0.00%> (ø)
unittests 95.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit f60bd09 into jaegertracing:main Jan 12, 2025
54 checks passed
@ary82 ary82 deleted the refactor-sampling-model branch January 13, 2025 17:40
ekefan pushed a commit to ekefan/jaeger that referenced this pull request Jan 14, 2025
…egertracing#6531)

## Which problem is this PR solving?
- Towards jaegertracing#6411 

## Description of the changes
- Involves refactoring the `model` package in
`cmd/collector/app/sampling`
- Move specific `plugin/storage/cassandra/samplingstore` types to that
package as internal types
- Move the other types to `storage/samplingstore/model`

## How was this change tested?
- Covered by existing

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

Signed-off-by: Aryan Goyal <137564277+ary82@users.noreply.github.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants