-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Move cmd/collector/app/sampling/model types to storage #6531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aryan Goyal <137564277+ary82@users.noreply.github.com>
yurishkuro
approved these changes
Jan 12, 2025
yurishkuro
changed the title
refactor: move cmd/collector/app/sampling/model types to storage
[refactor] Move cmd/collector/app/sampling/model types to storage
Jan 12, 2025
lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6531 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 372 372
Lines 21360 21360
=======================================
Hits 20551 20551
Misses 616 616
Partials 193 193
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ekefan
pushed a commit
to ekefan/jaeger
that referenced
this pull request
Jan 14, 2025
…egertracing#6531) ## Which problem is this PR solving? - Towards jaegertracing#6411 ## Description of the changes - Involves refactoring the `model` package in `cmd/collector/app/sampling` - Move specific `plugin/storage/cassandra/samplingstore` types to that package as internal types - Move the other types to `storage/samplingstore/model` ## How was this change tested? - Covered by existing ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Aryan Goyal <137564277+ary82@users.noreply.github.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
model
package incmd/collector/app/sampling
plugin/storage/cassandra/samplingstore
types to that package as internal typesstorage/samplingstore/model
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test