Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max Node version 17.x.x #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zeroby0
Copy link

@zeroby0 zeroby0 commented Nov 23, 2022

Heyo!

Builds currently fail with Node v18 and above on Netlify with this plugin (as well as with the https://github.com/zeroby0/netlify-plugin-11ty plugin I maintain).

Setting node version to <18.0.0 creates a warning and a better error message when building on versions 18 or above.

Example:

12:27:01 PM: npm WARN EBADENGINE Unsupported engine {
12:27:01 PM: npm WARN EBADENGINE   package: 'netlify-plugin-11ty@2.0.0-alpha',
12:27:01 PM: npm WARN EBADENGINE   required: { node: '>=12.18.0 <17.0.0' },
12:27:01 PM: npm WARN EBADENGINE   current: { node: 'v19.1.0', npm: '8.19.3' }
12:27:01 PM: npm WARN EBADENGINE }
12:27:30 PM: ──────────────────────────
12:27:30 PM:   Configuration error                                           
12:27:30 PM: ──────────────────────────
12:27:30 PM: ​
12:27:30 PM:   Error message
12:27:30 PM:   The Node.js version is 19.1.0 but the plugin "netlify-plugin-11ty" requires >=12.18.0 <17.0.0

Please also consider adding notes about failing builds in the readme. (example: https://github.com/zeroby0/netlify-plugin-11ty#my-builds-are-failing)

Thanks!!

Builds fail with Node v18 on Netlify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant