SMTPMailer adding ReplyTo in SMTP message header #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love it. If you look at the file This wouldn't test whether the SMTP protocol actually has the reply to field set, but it at least tests the mailable API to ensure it's okay up to the point before the email is actually sent off. |
jamesmh
reviewed
Jan 11, 2024
|
I fixed the extra space issue, and I also added another unit test that calls the ReplyTo fluent method. |
jamesmh
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for issue #357.
The reply to address is passed to the SendAysnc method but was not applied to the MimeMessage generated. This should be a non breaking change where if no ReplyTo address is supplied it is not added, while when a ReplyTo message is supplied it is added in the email header appropriately.
I tried making some unit tests but couldn't without adding a lot of extra code or packages.