Address pull request comments, add TODOs and issues

Cargo.toml

@@ -6,7 +6,7 @@ name = "std"
 version = "0.1.0"
 
 [dependencies]
-sc = { git = "git://github.com/japaric/syscall.rs" }
+sc = "0.2.0"
 
 [dependencies.ralloc]
 default-features = false

src/libc/internal/aarch64.rs

@@ -64,5 +64,5 @@ unsafe extern "C" fn __steed_clone() {
 }
 
 pub unsafe fn set_thread_pointer(thread_data: *mut ()) {
-    let _ = thread_data; // TODO(steed): Set thread-local pointer.
+    let _ = thread_data; // TODO(steed, #127): Set thread-local pointer.
 }

src/libc/internal/arm.rs

@@ -92,5 +92,5 @@ unsafe extern "C" fn __steed_clone() {
 }
 
 pub unsafe fn set_thread_pointer(thread_data: *mut ()) {
-    let _ = thread_data; // TODO(steed): Set thread-local pointer.
+    let _ = thread_data; // TODO(steed, #127): Set thread-local pointer.
 }

src/libc/internal/powerpc.rs

@@ -86,5 +86,5 @@ unsafe extern "C" fn __steed_clone() {
 }
 
 pub unsafe fn set_thread_pointer(thread_data: *mut ()) {
-    let _ = thread_data; // TODO(steed): Set thread-local pointer.
+    let _ = thread_data; // TODO(steed, #127): Set thread-local pointer.
 }

src/libc/internal/x86.rs

@@ -125,6 +125,8 @@ pub unsafe fn set_thread_pointer(thread_data: *mut ()) {
         entry_number: -1i32 as u32,
         base_addr: thread_data as u32,
         limit: 0xfffff,
+        // This `flags` value is explained in the `asm!` block of
+        // `__steed_clone` above.
         flags: 0x51,
     };
     let result = linux::set_thread_area(&mut user_desc);

src/libc/mod.rs

@@ -198,6 +198,8 @@ pub unsafe fn pthread_create(pthread: *mut pthread_t,
     let mask = align - 1;
     let stack_size = ((*attr).stack_size + mask) & !mask;
 
+    // TODO(steed, #131): Make sure this is freed on normal and abnormal thread
+    // exit.
     let map = mmap(ptr::null_mut(),
                    stack_size + mem::size_of::<thread>(),
                    PROT_READ | PROT_WRITE,
@@ -288,7 +290,7 @@ pub unsafe fn pthread_join(pthread: pthread_t, retval: *mut *mut c_void)
     if tmp == 0 {
         return 0;
     }
-    // TODO(steed): Why does FUTEX_WAIT_PRIVATE not work?
+    // TODO(steed, #130): Why does FUTEX_WAIT_PRIVATE not work?
     let res = linux::futex(&mut (*thread).thread_id as *mut _ as *mut u32,
                            linux::FUTEX_WAIT,
                            (*thread).thread_id as u32,

src/sys/linux/os.rs

@@ -16,6 +16,7 @@ pub fn exit(code: i32) -> ! {
 }
 
 pub fn page_size() -> usize {
+    // TODO(steed, #133): Implement me.
     unimplemented!();
 }
 

src/sys/linux/stack_overflow.rs

@@ -2,6 +2,7 @@ pub struct Handler(());
 
 impl Handler {
     pub unsafe fn new() -> Handler {
+        // TODO(steed, #132): Implement a stack overflow handler.
         Handler(())
     }
 }

src/sys/linux/thread.rs

@@ -183,6 +183,7 @@ impl Thread {
     */
 }
 
+// TODO(steed, #134): Implement `Drop` for `Thread`.
 /*
 impl Drop for Thread {
     fn drop(&mut self) {

src/thread/mod.rs

@@ -60,6 +60,7 @@ impl Builder {
                 imp::Thread::set_name(name);
             }
             unsafe {
+                // TODO(steed, #128): Add guard page to new threads.
                 /*
                 thread_info::set(imp::guard::current(), their_thread);
                 let try_result = panic::catch_unwind(panic::AssertUnwindSafe(f));
@@ -110,6 +111,7 @@ pub struct ThreadId(u64);
 impl ThreadId {
     // Generate a new unique thread ID.
     fn new() -> ThreadId {
+        // TODO(steed, #129): Use `std`s implementation (commented out below).
         /*
         static GUARD: mutex::Mutex = mutex::Mutex::new();
         static mut COUNTER: u64 = 0;