Optimize spike detection

DiscordClient/Program.cs

@@ -53,6 +53,8 @@ private static async Task Main()
         await client.LoginAsync(TokenType.Bot, ConfigManager.BotConfig.Token);
         await client.StartAsync();
 
+        flipperThread.Start();
+
         // Block the program until it is closed.
         bool shouldExit = false;
         while (!shouldExit)
@@ -149,8 +151,6 @@ private static async Task OnBotReady()
         Logger.Info($"Found {channels.Count} channels to post dump updates on.\n");
         Logger.Warn("Please do not close this window manually, but use the 'exit' command to close the bot gracefully.");
         Logger.Warn("Type 'help' for a list of commands.");
-
-        flipperThread.Start();
     }
 
 

OsrsFlipper/Filtering/Filters/FlipFilters/SpikeRemovalFilter.cs

@@ -27,24 +27,24 @@ protected override bool CanPassFilter(CacheEntry itemData, ItemPriceHistory hist
         // Get the latest high price.
         int latestHighPrice = itemData.PriceLatest.HighestPrice;
 
-        // Check the last 30 minutes (6 * 5min data points).
-        for (int i = 0; i < 6; i++)
+        // Check the last 15 minutes (3 * 5min data points).
+        for (int i = 0; i < 3; i++)
         {
             // Get the price before the latest price.
             ItemPriceHistoryEntry historyEntry = history5Min.Data[^(2 + i)];
 
             //TODO: Maybe some check for the price being too old?
 
-            int? historicalPrice = historyEntry.AvgHighPrice;
+            int? historicalPrice = historyEntry.HighestPrice;
 
             if (historicalPrice == null)
                 return false;
 
             // Calculate the percentage increase from the previous price to the latest price.
-            double percentageIncreaseFromHistory = ((double)latestHighPrice / historicalPrice.Value - 1) * 100;
+            double percentageIncreaseFromHistorical = ((double)latestHighPrice / historicalPrice.Value * 100) - 100d;
 
             // If the percentage increase is significantly high, consider it a price spike.
-            if (percentageIncreaseFromHistory > _maxHighPriceIncreasePercentage)
+            if (percentageIncreaseFromHistorical > _maxHighPriceIncreasePercentage)
                 return false;
         }
 

OsrsFlipper/Flipper.cs

@@ -12,7 +12,8 @@ namespace OsrsFlipper;
 
 public sealed class Flipper : IDisposable
 {
-    private const bool DEBUG_FILTERS = false;
+    private const bool DEBUG_FILTERS = true;
+    private const int MAX_PRUNE_PASS_COUNT = 75;
 
     /// <summary>
     /// The API controller used to fetch data from the OSRS API.
@@ -50,9 +51,9 @@ private Flipper(OsrsApiController apiController, ItemCache cache, int cooldownMi
         // Prune filters are used to quickly discard items that are not worth considering, and to avoid fetching additional API data for them.
         _filterCollection
             .AddPruneFilter(new ItemCooldownFilter(_cooldownManager)) // Skip items that are on a cooldown.
-            .AddPruneFilter(new TransactionAgeFilter(2, 10)) // Skip items that have not been traded in the last X minutes.
+            .AddPruneFilter(new TransactionAgeFilter(2, 8)) // Skip items that have not been traded in the last X minutes.
             .AddPruneFilter(new Item24HAveragePriceFilter(50, 50_000_000)) // Skip items with a 24-hour average price outside the range X - Y.
-            .AddPruneFilter(new TransactionVolumeFilter(2_000_000)) // Skip items with a transaction volume less than X gp.
+            .AddPruneFilter(new TransactionVolumeFilter(3_000_000)) // Skip items with a transaction volume less than X gp.
             .AddPruneFilter(new ReturnOfInvestmentFilter(4)); // Skip items with a return of investment less than X%.
             //.AddPruneFilter(new VolatilityFilter(12))                                        // Skip items with a price fluctuation of more than X% in the last 30 minutes.
 
@@ -67,7 +68,7 @@ private Flipper(OsrsApiController apiController, ItemCache cache, int cooldownMi
     /// <summary>
     /// Creates a new Flipper instance.
     /// </summary>
-    public static async Task<Flipper> Create(int cooldownMinutes = 5)
+    public static async Task<Flipper> Create(int cooldownMinutes = 8)
     {
         OsrsApiController apiController = new();
 
@@ -95,10 +96,10 @@ public async Task<List<ItemDump>> FindDumps()
         foreach (CacheEntry entry in _cache.Entries())
         {
             // Safety check: If the pruning filters somehow stop working (or there are none), we won't spam the user with messages and the API with requests.
-            if (itemsPassedPruneCount >= 50)
+            if (itemsPassedPruneCount >= MAX_PRUNE_PASS_COUNT)
             {
-                Logger.Warn("Over 50 items passed all pruning filters." +
-                            "This is not generally good, and will result in wasted resources." +
+                Logger.Warn($"Over {MAX_PRUNE_PASS_COUNT} items passed all pruning filters. " +
+                            "This is generally not good, and will result in wasted resources. " +
                             "Stopping dump search.");
                 break;
             }