Skip to content

Commit

Permalink
iter
Browse files Browse the repository at this point in the history
  • Loading branch information
javanna committed Apr 4, 2024
1 parent d2f3901 commit 53b2779
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ public Status needsField(FieldInfo fieldInfo) {
// Always load _ignored to be explicit about ignored fields
// This works because _ignored is added as the first metadata mapper,
// so its stored fields always appear first in the list.
//TODO this should still be needed for the get API, but no longer for the search api as _ignored is now retrieved
// TODO this should still be needed for the get API, but no longer for the search api as _ignored is now retrieved
// via value fetcher, hence a different visitor. It's FetchFieldsPhase that requests it explicitly every time.
//we may need to add test coverage for the GET API codepath, that seems missing
// we may need to add test coverage for the GET API codepath, that seems missing
if (IgnoredFieldMapper.NAME.equals(fieldInfo.name)) {
return Status.YES;
}
Expand Down

0 comments on commit 53b2779

Please sign in to comment.