Closes #267. Show error message from queries #272
Conversation
|
|
||
| if (searchResults.error) { | ||
| const {message} = searchResults.error | ||
| const spanStyle = {...style.span, color: 'red'} |
There was a problem hiding this comment.
Should use the red color from material-ui so that we have consistent colors.
import {red500} from 'material-ui/styles/colors'
//...
const spanStyle = {...style.span, color: red500}| const spanStyle = {...style.span, color: 'red'} | ||
| let text = {} | ||
|
|
||
| try { |
There was a problem hiding this comment.
Is there a reason we are doing this here and not inside the action?
There was a problem hiding this comment.
Another point here is why are we interpretting the "data" sent back from the rest side. why doesn't the rest side just figure out what to send and send it back as a string?
There was a problem hiding this comment.
This was so REST could send an error in any format. Sometimes we want the error formatted to display to a user. For example:
You do not have the correct LACs/COIs to view this data:
LACs: 123_456
COIs: ABC_DEF
A string does not allow this.
| let text = {} | ||
|
|
||
| try { | ||
| text = JSON.parse(message) |
There was a problem hiding this comment.
sane reason as above
knorris
force-pushed
the
error-utility
branch
from
2ba7200 to
83ecf31
Compare
No description provided.