-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #9522 for v4.3.x: Add csv to runtime dependency list #9736
Conversation
Hello @mathbruyen The Once the relevant changes are backported from |
Fixes #9741. |
Merge pull request 9522
9f77a74
to
0ec4d8c
Compare
Hello @ashmaroli any update on when the this will be resolved ? |
@cocallaw, I'm currently waiting for |
Yeah, this is the pr for the cucumber package cucumber/cucumber-ruby#1771 |
Actually, the concerned pull request is cucumber/cucumber-ruby#1773 |
Apologies, everyone! Introducing a runtime dependency is beyond the scope of a patch release. Therefore, this change won't be released as v4.3.x |
This backports 25fd87c to 4.3-stable
Context
Jekyll 4.3.4 fails to run on ruby 3.4 because
csv
dependency was removed from stdlib. Cherry-picked #9522 into4.3-stable
.This is not sufficient to get Jekyll to work on 3.4, liquid requires bigdecimal and safe_yaml requires base64.
safe_yaml
has not been released in the last 5 years, I don't know if it is still maintained. If not maybeSafeYAML.load
can be replaced byYAML.safe_load
.